Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc

Issue 1128113011: ozone: Introduce ClientPixmap and ClientPixmapFactory for non-GPU processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed nits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc
diff --git a/content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc b/content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc
index 2c69f5019613d216f6de429d031e40b50414b142..edbcdfcb0661c562a53b57ca5b36574cb626616a 100644
--- a/content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc
+++ b/content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc
@@ -5,23 +5,19 @@
#include "content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.h"
#include "ui/gl/gl_image_ozone_native_pixmap.h"
+#include "ui/ozone/public/client_native_pixmap_manager.h"
#include "ui/ozone/public/ozone_platform.h"
#include "ui/ozone/public/surface_factory_ozone.h"
namespace content {
namespace {
-const GpuMemoryBufferFactory::Configuration kSupportedConfigurations[] = {
- {gfx::GpuMemoryBuffer::BGRA_8888, gfx::GpuMemoryBuffer::SCANOUT},
- {gfx::GpuMemoryBuffer::RGBX_8888, gfx::GpuMemoryBuffer::SCANOUT}};
-
-ui::SurfaceFactoryOzone::BufferFormat GetOzoneFormatFor(
- gfx::GpuMemoryBuffer::Format format) {
+ui::NativePixmapFormat GetOzoneFormatFor(gfx::GpuMemoryBuffer::Format format) {
switch (format) {
case gfx::GpuMemoryBuffer::BGRA_8888:
- return ui::SurfaceFactoryOzone::BGRA_8888;
+ return ui::NATIVE_PIXMAP_FORMAT_BGRA_8888;
case gfx::GpuMemoryBuffer::RGBX_8888:
- return ui::SurfaceFactoryOzone::RGBX_8888;
+ return ui::NATIVE_PIXMAP_FORMAT_RGBX_8888;
case gfx::GpuMemoryBuffer::ATC:
case gfx::GpuMemoryBuffer::ATCIA:
case gfx::GpuMemoryBuffer::DXT1:
@@ -32,26 +28,64 @@ ui::SurfaceFactoryOzone::BufferFormat GetOzoneFormatFor(
case gfx::GpuMemoryBuffer::RGBA_8888:
case gfx::GpuMemoryBuffer::YUV_420:
NOTREACHED();
- return ui::SurfaceFactoryOzone::BGRA_8888;
+ return ui::NATIVE_PIXMAP_FORMAT_BGRA_8888;
}
NOTREACHED();
- return ui::SurfaceFactoryOzone::BGRA_8888;
+ return ui::NATIVE_PIXMAP_FORMAT_BGRA_8888;
}
-ui::SurfaceFactoryOzone::BufferUsage GetOzoneUsageFor(
- gfx::GpuMemoryBuffer::Usage usage) {
+ui::NativePixmapUsage GetOzoneUsageFor(gfx::GpuMemoryBuffer::Usage usage) {
switch (usage) {
case gfx::GpuMemoryBuffer::MAP:
- return ui::SurfaceFactoryOzone::MAP;
+ return ui::NATIVE_PIXMAP_USAGE_MAP;
case gfx::GpuMemoryBuffer::PERSISTENT_MAP:
- return ui::SurfaceFactoryOzone::PERSISTENT_MAP;
+ return ui::NATIVE_PIXMAP_USAGE_PERSISTENT_MAP;
case gfx::GpuMemoryBuffer::SCANOUT:
- return ui::SurfaceFactoryOzone::SCANOUT;
+ return ui::NATIVE_PIXMAP_USAGE_SCANOUT;
+ }
+
+ NOTREACHED();
+ return ui::NATIVE_PIXMAP_USAGE_MAP;
+}
+
+gfx::GpuMemoryBuffer::Format GetGpuMemoryBufferFormatFor(
+ ui::NativePixmapFormat ozone_format) {
+ switch (ozone_format) {
+ case ui::NATIVE_PIXMAP_FORMAT_BGRA_8888:
+ return gfx::GpuMemoryBuffer::BGRA_8888;
+ case ui::NATIVE_PIXMAP_FORMAT_RGBX_8888:
+ return gfx::GpuMemoryBuffer::RGBX_8888;
}
+ NOTREACHED();
+ return gfx::GpuMemoryBuffer::BGRA_8888;
+}
+gfx::GpuMemoryBuffer::Usage GetGpuMemoryBufferUsageFor(
+ ui::NativePixmapUsage ozone_usage) {
+ switch (ozone_usage) {
+ case ui::NATIVE_PIXMAP_USAGE_MAP:
+ return gfx::GpuMemoryBuffer::MAP;
+ case ui::NATIVE_PIXMAP_USAGE_PERSISTENT_MAP:
+ return gfx::GpuMemoryBuffer::PERSISTENT_MAP;
+ case ui::NATIVE_PIXMAP_USAGE_SCANOUT:
+ return gfx::GpuMemoryBuffer::SCANOUT;
+ }
NOTREACHED();
- return ui::SurfaceFactoryOzone::MAP;
+ return gfx::GpuMemoryBuffer::MAP;
+}
+
+void GetSupportedConfigurations(
+ std::vector<GpuMemoryBufferFactory::Configuration>* configurations) {
+ std::vector<ui::ClientNativePixmapManager::Configuration>
+ native_pixmap_configurations =
+ ui::ClientNativePixmapManager::GetInstance()
+ ->GetSupportedConfigurations();
+ for (auto& native_pixmap_configuration : native_pixmap_configurations) {
+ configurations->push_back(
+ {GetGpuMemoryBufferFormatFor(native_pixmap_configuration.format),
+ GetGpuMemoryBufferUsageFor(native_pixmap_configuration.usage)});
+ }
}
} // namespace
@@ -66,7 +100,9 @@ GpuMemoryBufferFactoryOzoneNativePixmap::
bool GpuMemoryBufferFactoryOzoneNativePixmap::
IsGpuMemoryBufferConfigurationSupported(gfx::GpuMemoryBuffer::Format format,
gfx::GpuMemoryBuffer::Usage usage) {
- for (auto& configuration : kSupportedConfigurations) {
+ std::vector<Configuration> configurations;
+ GetSupportedConfigurations(&configurations);
+ for (auto& configuration : configurations) {
if (configuration.format == format && configuration.usage == usage)
return true;
}
@@ -77,14 +113,7 @@ bool GpuMemoryBufferFactoryOzoneNativePixmap::
void GpuMemoryBufferFactoryOzoneNativePixmap::
GetSupportedGpuMemoryBufferConfigurations(
std::vector<Configuration>* configurations) {
- if (!ui::OzonePlatform::GetInstance()
- ->GetSurfaceFactoryOzone()
- ->CanCreateNativePixmap(ui::SurfaceFactoryOzone::SCANOUT))
- return;
-
- configurations->assign(
- kSupportedConfigurations,
- kSupportedConfigurations + arraysize(kSupportedConfigurations));
+ GetSupportedConfigurations(configurations);
}
gfx::GpuMemoryBufferHandle

Powered by Google App Engine
This is Rietveld 408576698