content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc - Issue 1128113011: ozone: Introduce ClientPixmap and ClientPixmapFactory for non-GPU processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc

Issue 1128113011: ozone: Introduce ClientPixmap and ClientPixmapFactory for non-GPU processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed nits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/app/content_main_runner.cc ('K') | « content/browser/browser_main_loop.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | ui/ozone/common/stub_client_native_pixmap_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc

diff --git a/content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc b/content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc

index d21121b96f1ff9d325395244e710065ed4789873..7bac66fdd276ed54b6ae2056f63b1c483aacc94b 100644

--- a/content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc

+++ b/content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc

@@ -8,13 +8,13 @@

namespace content {

-static ui::SurfaceFactoryOzone::BufferFormat GetOzoneFormat(

+static ui::NativePixmapFormat GetOzoneFormat(

cc::ResourceFormat overlay_format) {

switch (overlay_format) {

// TODO(dshwang): overlay video still uses RGBA_8888.

case cc::RGBA_8888:

case cc::BGRA_8888:

- return ui::SurfaceFactoryOzone::BGRA_8888;

+ return ui::NATIVE_PIXMAP_FORMAT_BGRA_8888;

case cc::RGBA_4444:

case cc::ALPHA_8:

case cc::LUMINANCE_8:

@@ -24,7 +24,7 @@ static ui::SurfaceFactoryOzone::BufferFormat GetOzoneFormat(

break;

}

NOTREACHED();

- return ui::SurfaceFactoryOzone::UNKNOWN;

+ return ui::NATIVE_PIXMAP_FORMAT_BGRA_8888;

}

BrowserCompositorOverlayCandidateValidatorOzone::