ozone: Introduce ClientPixmap and ClientPixmapFactory for non-GPU processes.

content/test/content_test_suite.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/test/content_test_suite.h"
 
 #include "base/base_paths.h"
 #include "base/logging.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_paths.h"
@@ skipping 17 matching lines @@
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "media/base/media.h"
 #include "ui/gl/test/gl_surface_test_support.h"
 #endif
 
 #if defined(OS_ANDROID)
 #include "content/browser/android/in_process_surface_texture_manager.h"
 #endif
 
+#if defined(USE_OZONE)
+#include "ui/ozone/public/native_pixmap_manager.h"
+#endif
+
 namespace content {
 namespace {
 
 class TestInitializationListener : public testing::EmptyTestEventListener {
  public:
   TestInitializationListener() : test_content_client_initializer_(NULL) {
   }
 
   void OnTestStart(const testing::TestInfo& test_info) override {
     test_content_client_initializer_ =
@@ skipping 34 matching lines @@
   ContentTestSuiteBase::Initialize();
   {
     ContentClient client;
     ContentTestSuiteBase::RegisterContentSchemes(&client);
   }
   RegisterPathProvider();
 #if !defined(OS_IOS)
   media::InitializeMediaLibrary();
   // When running in a child process for Mac sandbox tests, the sandbox exists
   // to initialize GL, so don't do it here.
-  if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kTestChildProcess)) {
+  bool is_child_process = base::CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kTestChildProcess);
+  if (!is_child_process) {
     gfx::GLSurfaceTestSupport::InitializeOneOff();
     gpu::ApplyGpuDriverBugWorkarounds(base::CommandLine::ForCurrentProcess());
   }
 #endif
   testing::TestEventListeners& listeners =
       testing::UnitTest::GetInstance()->listeners();
   listeners.Append(new TestInitializationListener);
 #if defined(OS_ANDROID)
   SurfaceTextureManager::SetInstance(
       InProcessSurfaceTextureManager::GetInstance());
 #endif
 #if defined(OS_MACOSX) && !defined(OS_IOS)
   IOSurfaceManager::SetInstance(InProcessIOSurfaceManager::GetInstance());
 #endif
+#if defined(USE_OZONE)
+  if (!is_child_process) {

[reveman, 2015/07/23 14:46:12]

why do you need this "!is_child_process" check?

[dshwang, 2015/07/23 16:42:09]

good question. why gfx::GLSurfaceTestSupport::InitializeOneOff() needs
"!is_child_process" check? InitializeOneOff() internally initialize ozone. So I
initialize NativePixmapManager when ozone is initialized.
I don't fully understand what is |is_child_process| purpose.

[reveman, 2015/07/23 18:25:23]

Well it's probably called later in that case. Maybe this is too early to call
ui::NativePixmapManager::Create() if you need ozone to be initialized.

[dshwang, 2015/07/24 12:19:00]

I'm fixing unittests for ozone in https://codereview.chromium.org/1208603002/
I'll handle "is_child_process" case later if needed.

+    DCHECK(!ui::NativePixmapManager::GetInstance());

[reveman, 2015/07/23 14:46:12]

nit: remove this DCHECK, SetInstance already does this.

[dshwang, 2015/07/23 16:42:09]

Done.

+    ui::NativePixmapManager::SetInstance(ui::NativePixmapManager::Create());

[reveman, 2015/07/23 14:46:12]

should we be using CreateNativePixmapManagerTest() here?

[dshwang, 2015/07/23 16:42:09]

CreateNativePixmapManagerTest() is not public for another module.
I'll create TestNativePixmapManager in next CL like previous patch set.

+  }
+#endif
 }
 
 }  // namespace content