content/common/gpu/native_pixmap_manager_ozone_messages.h - Issue 1128113011: ozone: Introduce ClientPixmap and ClientPixmapFactory for non-GPU processes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/gpu/native_pixmap_manager_ozone_messages.h

Issue 1128113011: ozone: Introduce ClientPixmap and ClientPixmapFactory for non-GPU processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: NativePixmapManager is singleton Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/child/child_gpu_memory_buffer_manager.cc ('K') | « content/common/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc ('k') | content/content_browser.gypi » ('j') | ui/ozone/public/native_pixmap_manager.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_COMMON_COMMON_GPU_NATIVE_PIXMAP_MANAGER_OZONE_MESSAGES_H_

	6 #define CONTENT_COMMON_COMMON_GPU_NATIVE_PIXMAP_MANAGER_OZONE_MESSAGES_H_

	7

	8 #include "base/file_descriptor_posix.h"

	9 #include "ipc/ipc_message_macros.h"

	10

	11 #define IPC_MESSAGE_START BrowserNativePixmapManagerMsgStart

	12

	13 // Messages sent to BrowserNativePixmapManager.

	14 // Asks the browser to reply virtual device fd.

	15 IPC_SYNC_MESSAGE_CONTROL0_1(BrowserNativePixmapManagerMsg_SyncGetVirtualDevice,
	dshwang 2015/07/06 18:45:01 Done. renamed. Show quoted text > nit: "Reply" in the name of a request is awkward. I guess this should be called > SyncGetVirtualDevice but see my comment below. Done. renamed. Show quoted text > Can we pass this asynchronously to the child process instead of requiring a > round-trip at startup? Take a look at how we pass IOSurfaceManager tokens to > child processes. I couldn't find the way. BrowserIOSurfaceManager::Initialize registers mach token into kernel, and then BrowserIOSurfaceManager::LookupServicePort in renderer looks up the token from kernel. In this sense, Browser needs to register VGEM FD into linux kernel. There is no way. In addition, Browser and Renderer cannot communicate until the channel is connected (i.e. ChildThreadImpl::OnChannelConnected())
	16 base::FileDescriptor /* device_fd */)

	17

	18 #endif // CONTENT_COMMON_COMMON_GPU_NATIVE_PIXMAP_MANAGER_OZONE_MESSAGES_H_

OLD	NEW