Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1128113006: Add the concept of a V8 extras exports object (Closed)

Created:
5 years, 7 months ago by domenic
Modified:
5 years, 7 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add the concept of a V8 extras exports object Exposed to the extras as extrasExports (on the builtins object), on which they can put things that should be accessible from C++. Exposed to C++ through the V8 API as v8::Context::GetExtrasExportsObject(). Adding a test (in test-api.cc) required adding a simple extra, test-extra.js, which we build into the standalone builds. R=yangguo@chromium.org, jochen@chromium.org BUG= Committed: https://crrev.com/ad547cea05f3e02c67243b682e933fc53ac763d9 Cr-Commit-Position: refs/heads/master@{#28317}

Patch Set 1 #

Patch Set 2 : Trying to rebase on previous CL #

Patch Set 3 : Updated to put the exports object on the builtins object instead of using a % function #

Patch Set 4 : Rebase on top of fixed natives change #

Patch Set 5 : Was mising test-extra.js :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -4 lines) Patch
M build/standalone.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M include/v8.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 chunks +16 lines, -0 lines 0 comments Download
M src/contexts.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
A + test/cctest/test-extra.js View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
domenic
5 years, 7 months ago (2015-05-07 09:21:37 UTC) #1
domenic
Updated to put the exports object on the builtins object instead of using a %GetExtrasExportsObject() ...
5 years, 7 months ago (2015-05-07 13:09:46 UTC) #2
Yang
On 2015/05/07 13:09:46, domenic wrote: > Updated to put the exports object on the builtins ...
5 years, 7 months ago (2015-05-07 14:03:54 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-07 15:01:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128113006/60001
5 years, 7 months ago (2015-05-08 10:18:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/5645)
5 years, 7 months ago (2015-05-08 10:21:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128113006/80001
5 years, 7 months ago (2015-05-08 11:24:51 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-08 12:06:40 UTC) #13
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/ad547cea05f3e02c67243b682e933fc53ac763d9 Cr-Commit-Position: refs/heads/master@{#28317}
5 years, 7 months ago (2015-05-08 12:06:55 UTC) #14
Michael Achenbach
This causes gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/2167
5 years, 7 months ago (2015-05-08 14:40:27 UTC) #15
Michael Achenbach
5 years, 7 months ago (2015-05-11 08:19:32 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1127313005/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Causes gc stress failures:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s....

Powered by Google App Engine
This is Rietveld 408576698