Issue 1128093003: Revert of Schedule garbage collection on worker threads using idle tasks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1128093003: Revert of Schedule garbage collection on worker threads using idle tasks (Closed)

Created:
5 years, 7 months ago by Sami

Modified:
5 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit), rmcilroy, alex clarke (OOO till 29th)

CC:
blink-reviews, falken, horo+watch_chromium.org, kinuko+worker_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Schedule garbage collection on worker threads using idle tasks (patchset #3 id:40001 of https://codereview.chromium.org/1130413003/) Reason for revert: Looks like the new tests are flaky on Windows, e.g: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/29682 Original issue's description: > Schedule garbage collection on worker threads using idle tasks > > Original patch by Alex Clarke <alexclarke@chromium.org>;. > > BUG=463143 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195243 TBR=jochen@chromium.org,rmcilroy@chromium.org,alexclarke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463143 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195260

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -242 lines)			Patch
M	Source/core/workers/WorkerThread.h	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	Source/core/workers/WorkerThread.cpp	View	7 chunks	+18 lines, -44 lines	0 comments	Download
M	Source/core/workers/WorkerThreadTest.cpp	View	5 chunks	+0 lines, -192 lines	0 comments	Download

Total messages: 3 (0 generated)

Sami

Created Revert of Schedule garbage collection on worker threads using idle tasks

5 years, 7 months ago (2015-05-12 16:01:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128093003/1

5 years, 7 months ago (2015-05-12 16:02:07 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-12 16:02:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195260