Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1128093002: Return vertical writing mode aware intrinsic information for SVG (Closed)

Created:
5 years, 7 months ago by davve
Modified:
5 years, 7 months ago
Reviewers:
pdr., kojii, fs
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Return vertical writing mode aware intrinsic information for SVG Values returned from computeIntrinsicRatioInformation are assumed to be logical, i.e. they should take writing mode into consideration. BUG=484425 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195059

Patch Set 1 #

Patch Set 2 : Rebase for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M LayoutTests/svg/in-html/sizing/svg-inline-vertical-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGRoot.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
davve
PTAL
5 years, 7 months ago (2015-05-06 13:52:11 UTC) #2
davve
5 years, 7 months ago (2015-05-07 07:00:09 UTC) #4
fs
lgtm
5 years, 7 months ago (2015-05-07 10:52:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128093002/20001
5 years, 7 months ago (2015-05-07 14:55:08 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 16:36:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195059

Powered by Google App Engine
This is Rietveld 408576698