Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 1128083004: Tesellating path renderer: typecast cleanup; logging build fix. (Closed)

Created:
5 years, 7 months ago by Stephen White
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Tesellating path renderer: typecast cleanup; logging build fix. Use SkPoint* for all vertex data. (It was void* to support two different vertex data formats, which we no longer need.) Assert that vertex stride == sizeof(SkPoint). Fix build when LOGGING_ENABLED=1. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d4d83eb032845b7aefbeeb717bdb3faeba864aa9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/gpu/GrTessellatingPathRenderer.cpp View 6 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Stephen White
robertphillips@: PTAL. Thanks!
5 years, 7 months ago (2015-05-14 15:27:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128083004/1
5 years, 7 months ago (2015-05-14 15:30:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-14 15:40:03 UTC) #6
robertphillips
lgtm
5 years, 7 months ago (2015-05-14 15:46:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128083004/1
5 years, 7 months ago (2015-05-14 16:07:55 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 16:08:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d4d83eb032845b7aefbeeb717bdb3faeba864aa9

Powered by Google App Engine
This is Rietveld 408576698