net/url_request/url_request.h - Issue 1128083003: Converted bare pointer to scoped_ptr in net/url_request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request.h

Issue 1128083003: Converted bare pointer to scoped_ptr in net/url_request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request.h

diff --git a/net/url_request/url_request.h b/net/url_request/url_request.h

index e623c202e71f1b0ed412e5998cd51f0015e3ab3b..492b71b14423f85ec8da6dfacc8adf62233362d9 100644

--- a/net/url_request/url_request.h

+++ b/net/url_request/url_request.h

@@ -365,7 +365,7 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),

// Returns a partial representation of the request's state as a value, for

// debugging. Caller takes ownership of returned value.

eroman 2015/05/11 19:00:07 Delete the comment "Caller takes ownership of retu

- base::Value* GetStateAsValue() const;

+ scoped_ptr<base::Value> GetStateAsValue() const;

// Logs information about the what external object currently blocking the

// request. LogUnblocked must be called before resuming the request. This

« no previous file with comments | « net/log/net_log_util.cc ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »