Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate.h

Issue 1128073003: [Smart Lock] Make link from brading string (Google Smart Lock) in save password infobar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/save_password_infobar_delegate.h
diff --git a/chrome/browser/password_manager/save_password_infobar_delegate.h b/chrome/browser/password_manager/save_password_infobar_delegate.h
index 6b4e2a4b28d142587757d513a03ab101b531fa16..21cd6a3e01d83c714f0084692da2472b47d665c4 100644
--- a/chrome/browser/password_manager/save_password_infobar_delegate.h
+++ b/chrome/browser/password_manager/save_password_infobar_delegate.h
@@ -11,6 +11,7 @@
#include "components/infobars/core/confirm_infobar_delegate.h"
#include "components/password_manager/core/browser/password_form_manager.h"
#include "components/password_manager/core/browser/password_manager_metrics_util.h"
+#include "ui/gfx/range/range.h"
namespace content {
class WebContents;
@@ -46,6 +47,8 @@ class SavePasswordInfoBarDelegate : public ConfirmInfoBarDelegate {
// Android it should display the "More" button.
bool ShouldShowMoreButton();
+ const gfx::Range& title_link_range() const { return title_link_range_; }
+
// ConfirmInfoBarDelegate:
Type GetInfoBarType() const override;
InfoBarAutomationType GetInfoBarAutomationType() const override;
@@ -54,6 +57,7 @@ class SavePasswordInfoBarDelegate : public ConfirmInfoBarDelegate {
void InfoBarDismissed() override;
base::string16 GetMessageText() const override;
base::string16 GetButtonLabel(InfoBarButton button) const override;
+ bool LinkClicked(WindowOpenDisposition disposition) override;
bool Accept() override;
bool Cancel() override;
@@ -88,6 +92,9 @@ class SavePasswordInfoBarDelegate : public ConfirmInfoBarDelegate {
// Title for the infobar: branded as a part of Google Smart Lock for signed
// users.
base::string16 title_;
+ // If title contains Google Smart Lock, then it should be link to help center
gone 2015/05/13 18:33:25 nit: add blank line above Maybe: If set, describe
melandory 2015/05/13 22:30:04 Definitely better. Thanks for suggested improvemen
+ // article.
+ gfx::Range title_link_range_;
DISALLOW_COPY_AND_ASSIGN(SavePasswordInfoBarDelegate);
};

Powered by Google App Engine
This is Rietveld 408576698