Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1128053004: Turn on Sk4px xfermodes when we have NEON too. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Turn on Sk4px xfermodes when we have NEON too. For SSE, Sk4px is better than Sk4f is better than SkXfermodes_opts_SSE2 (where implemented). For NEON, Sk4px is better than SkXfermodes_opts_arm_neon is better than Sk4f (where implemented). This is a 1.6-1.9x speedup for Plus,Modulate, and Screen for NEON. BUG=skia: Committed: https://skia.googlesource.com/skia/+/04d24a3f86b6f2382e5c6ffaf161ffc734a4d02a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -57 lines) Patch
M src/core/SkXfermode.cpp View 4 chunks +28 lines, -57 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 7 months ago (2015-05-12 21:30:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128053004/1
5 years, 7 months ago (2015-05-12 22:49:03 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 22:58:07 UTC) #6
reed1
lgtm
5 years, 7 months ago (2015-05-13 14:57:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128053004/1
5 years, 7 months ago (2015-05-13 15:01:58 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 15:02:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/04d24a3f86b6f2382e5c6ffaf161ffc734a4d02a

Powered by Google App Engine
This is Rietveld 408576698