Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1128053002: Fix FreeBSD build. (Closed)

Created:
5 years, 7 months ago by bnoordhuis
Modified:
5 years, 7 months ago
Reviewers:
titzer, saper
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix FreeBSD build. Fix the following build error: ../deps/v8/src/compiler/graph-visualizer.h:23:1: error: 'FILE' does not name a type See https://github.com/iojs/io.js/issues/1637 for background. BUG=v8:4079 LOG=N Committed: https://crrev.com/8ceb90356b0098c7df01678359535e4ed4bf05e8 Cr-Commit-Position: refs/heads/master@{#28254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler/graph-visualizer.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bnoordhuis
5 years, 7 months ago (2015-05-06 10:28:26 UTC) #2
titzer
lgtm
5 years, 7 months ago (2015-05-06 10:32:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128053002/1
5 years, 7 months ago (2015-05-06 10:32:55 UTC) #5
saper
Confirmed fixing the issue on FreeBSD 8.4 amd64 and i386 using gcc 4.8.4
5 years, 7 months ago (2015-05-06 10:38:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 10:57:04 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 10:57:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ceb90356b0098c7df01678359535e4ed4bf05e8
Cr-Commit-Position: refs/heads/master@{#28254}

Powered by Google App Engine
This is Rietveld 408576698