Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1128043008: cc: Don't try set renderpasses on active tree after losing context. (Closed)

Created:
5 years, 7 months ago by danakj
Modified:
5 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), jbauman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Don't try set RenderPasses on active tree after losing context. DelegatedRendererLayerImpl passes the frame from the pending to the active tree, but relies on there being a child_id_ on the active layer that is known to the ResourceProvider. If the context was lost while the frame was in the pending tree, the frames resources are released, but we try to tell the resource provider to use the empty frame with an invalid child id. When the context is lost and we drop the frame, also unset the bool saying we have a frame to pass to the active tree. R=piman@chromium.org BUG=488366 Committed: https://crrev.com/ce0d180446f7f0c78d84c0a872eefd4cddf79895 Cr-Commit-Position: refs/heads/master@{#330256}

Patch Set 1 #

Total comments: 2

Patch Set 2 : drlcrash: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M cc/layers/delegated_renderer_layer_impl.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_delegated.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
danakj
5 years, 7 months ago (2015-05-15 18:24:12 UTC) #1
piman
lgtm
5 years, 7 months ago (2015-05-15 23:17:04 UTC) #2
piman
https://codereview.chromium.org/1128043008/diff/1/cc/layers/delegated_renderer_layer_impl.cc File cc/layers/delegated_renderer_layer_impl.cc (right): https://codereview.chromium.org/1128043008/diff/1/cc/layers/delegated_renderer_layer_impl.cc#newcode80 cc/layers/delegated_renderer_layer_impl.cc:80: if (have_render_passes_to_push_) { Oh, can you add a DCHECK(child_id_) ...
5 years, 7 months ago (2015-05-15 23:17:38 UTC) #3
danakj
https://codereview.chromium.org/1128043008/diff/1/cc/layers/delegated_renderer_layer_impl.cc File cc/layers/delegated_renderer_layer_impl.cc (right): https://codereview.chromium.org/1128043008/diff/1/cc/layers/delegated_renderer_layer_impl.cc#newcode80 cc/layers/delegated_renderer_layer_impl.cc:80: if (have_render_passes_to_push_) { On 2015/05/15 23:17:38, piman (Very slow ...
5 years, 7 months ago (2015-05-15 23:31:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043008/20001
5 years, 7 months ago (2015-05-15 23:33:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-16 01:06:52 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:30:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce0d180446f7f0c78d84c0a872eefd4cddf79895
Cr-Commit-Position: refs/heads/master@{#330256}

Powered by Google App Engine
This is Rietveld 408576698