Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 1128043006: [destructuring] Adapting PatternRewriter to work in for-statements. (Closed)

Created:
5 years, 7 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[destructuring] Adapting PatternRewriter to work in C-style for-statements. BUG=v8:811 LOG=N Committed: https://crrev.com/7f6ae2300b5da1a1118d14375d8113973e526153 Cr-Commit-Position: refs/heads/master@{#28417}

Patch Set 1 #

Total comments: 8

Patch Set 2 : All tests pass. Geht's weiter #

Patch Set 3 : rebase #

Patch Set 4 : for statement works #

Patch Set 5 : Ready for review #

Patch Set 6 : Comments updated #

Patch Set 7 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -261 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.h View 1 2 3 4 2 chunks +85 lines, -7 lines 0 comments Download
M src/parser.cc View 1 2 3 4 5 12 chunks +129 lines, -122 lines 0 comments Download
D src/pattern-rewriter.h View 1 chunk +0 lines, -82 lines 0 comments Download
M src/pattern-rewriter.cc View 1 2 3 4 9 chunks +47 lines, -48 lines 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
Dmitry Lomov (no reviews)
Work in progress for lulz and horrorz. I'll probably rewrite a lot here.
5 years, 7 months ago (2015-05-13 16:10:10 UTC) #2
arv (Not doing code reviews)
Seems like a step in the right direction. https://codereview.chromium.org/1128043006/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/1128043006/diff/1/src/parser.cc#newcode2425 src/parser.cc:2425: Expect(Token::ASSIGN, ...
5 years, 7 months ago (2015-05-13 16:29:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043006/20001
5 years, 7 months ago (2015-05-14 10:57:20 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/373)
5 years, 7 months ago (2015-05-14 10:58:24 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043006/40001
5 years, 7 months ago (2015-05-14 11:14:54 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/375)
5 years, 7 months ago (2015-05-14 11:17:37 UTC) #13
Dmitry Lomov (no reviews)
This is ready for review. What is done in this CL is mostly refactoring. I ...
5 years, 7 months ago (2015-05-14 16:28:00 UTC) #14
arv (Not doing code reviews)
LGTM You have a todo about updating a comment. Now would be a good time ...
5 years, 7 months ago (2015-05-14 19:30:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043006/120001
5 years, 7 months ago (2015-05-15 09:31:15 UTC) #18
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 7 months ago (2015-05-15 09:56:35 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 09:56:50 UTC) #20
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/7f6ae2300b5da1a1118d14375d8113973e526153
Cr-Commit-Position: refs/heads/master@{#28417}

Powered by Google App Engine
This is Rietveld 408576698