[destructuring] Adapting PatternRewriter to work in for-statements.

[destructuring] Adapting PatternRewriter to work in C-style for-statements.

BUG=v8:811
LOG=N

Committed: https://crrev.com/7f6ae2300b5da1a1118d14375d8113973e526153
Cr-Commit-Position: refs/heads/master@{#28417}

[Dmitry Lomov (no reviews), 2015-05-13 16:10:10]

dslomov@chromium.org changed reviewers:
+ arv@chromium.org, rossberg@chromium.org

[Dmitry Lomov (no reviews), 2015-05-13 16:10:10]

Work in progress for lulz and horrorz.
I'll probably rewrite a lot here.

[arv (Not doing code reviews), 2015-05-13 16:29:29]

Seems like a step in the right direction.

https://codereview.chromium.org/1128043006/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1128043006/diff/1/src/parser.cc#newcode2425
src/parser.cc:2425: Expect(Token::ASSIGN, ok);
Maybe add a macro for CHECK_OK_VOID?

https://codereview.chromium.org/1128043006/diff/1/src/parser.cc#newcode2470
src/parser.cc:2470: parsing_result->out = first_name;
rename out?

https://codereview.chromium.org/1128043006/diff/1/src/parser.cc#newcode3468
src/parser.cc:3468: ParseVariableDeclarations(kForStatement, &parsing_result,
CHECK_OK);
Can this code be shared with the sloppy branch?

https://codereview.chromium.org/1128043006/diff/1/src/pattern-rewriter.cc
File src/pattern-rewriter.cc (right):

https://codereview.chromium.org/1128043006/diff/1/src/pattern-rewriter.cc#new...
src/pattern-rewriter.cc:27: VisitorState state;
or maybe:

VisitorState state(block, decl, names, ok);

[Dmitry Lomov (no reviews), 2015-05-14 10:57:04]

The CQ bit was checked by dslomov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-14 10:57:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128043006/20001

[commit-bot: I haz the power, 2015-05-14 10:58:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 10:58:24]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/373)

[Dmitry Lomov (no reviews), 2015-05-14 11:14:41]

The CQ bit was unchecked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-05-14 11:14:41]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-05-14 11:14:43]

The CQ bit was checked by dslomov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-14 11:14:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128043006/40001

[commit-bot: I haz the power, 2015-05-14 11:17:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 11:17:37]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/375)

[Dmitry Lomov (no reviews), 2015-05-14 16:28:00]

This is ready for review. What is done in this CL is mostly refactoring. I only
support C-style for loops in this CL.
Various forms of for-each made the CLe mashroom out of control, so I'll do that
in subsequent CLs.

https://codereview.chromium.org/1128043006/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1128043006/diff/1/src/parser.cc#newcode2425
src/parser.cc:2425: Expect(Token::ASSIGN, ok);
On 2015/05/13 16:29:29, arv wrote:
> Maybe add a macro for CHECK_OK_VOID?

Considered this but decided against. Too many CHECK_OK macros...

https://codereview.chromium.org/1128043006/diff/1/src/parser.cc#newcode2470
src/parser.cc:2470: parsing_result->out = first_name;
On 2015/05/13 16:29:29, arv wrote:
> rename out?

I did one better and removed it completely

https://codereview.chromium.org/1128043006/diff/1/src/parser.cc#newcode3468
src/parser.cc:3468: ParseVariableDeclarations(kForStatement, &parsing_result,
CHECK_OK);
On 2015/05/13 16:29:29, arv wrote:
> Can this code be shared with the sloppy branch?

Maybe in the next CL; I shared some.

https://codereview.chromium.org/1128043006/diff/1/src/pattern-rewriter.cc
File src/pattern-rewriter.cc (right):

https://codereview.chromium.org/1128043006/diff/1/src/pattern-rewriter.cc#new...
src/pattern-rewriter.cc:27: VisitorState state;
On 2015/05/13 16:29:29, arv wrote:
> or maybe:
> 
> VisitorState state(block, decl, names, ok);

State removed.

[arv (Not doing code reviews), 2015-05-14 19:30:05]

LGTM

You have a todo about updating a comment. Now would be a good time to do that.

[Dmitry Lomov (no reviews), 2015-05-15 09:31:01]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-05-15 09:31:01]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1128043006/#ps120001
(title: "Rebased")

[commit-bot: I haz the power, 2015-05-15 09:31:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128043006/120001

[commit-bot: I haz the power, 2015-05-15 09:56:35]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-05-15 09:56:50]

Patchset 7 (id:??) landed as
https://crrev.com/7f6ae2300b5da1a1118d14375d8113973e526153
Cr-Commit-Position: refs/heads/master@{#28417}