Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 1128043005: Map::ReconfigureProperty() should mark map as unstable when there is an element kind transition som… (Closed)

Created:
5 years, 7 months ago by Igor Sheludko
Modified:
5 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Map::ReconfigureProperty() should mark map as unstable when there is an element kind transition somewhere in the middle of the transition tree. BUG=chromium:485548 LOG=N Committed: https://crrev.com/3c1487db6088671425effe1ff523fae94a34e19f Cr-Commit-Position: refs/heads/master@{#28418}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -1 line) Patch
M src/objects.cc View 2 chunks +9 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-485548-1.js View 1 chunk +33 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-485548-2.js View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Igor Sheludko
PTAL
5 years, 7 months ago (2015-05-13 15:36:55 UTC) #3
Toon Verwaest
lgtm
5 years, 7 months ago (2015-05-15 09:31:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043005/40001
5 years, 7 months ago (2015-05-15 10:17:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 7 months ago (2015-05-15 10:40:09 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 10:40:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c1487db6088671425effe1ff523fae94a34e19f
Cr-Commit-Position: refs/heads/master@{#28418}

Powered by Google App Engine
This is Rietveld 408576698