Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: src/heap/identity-map.cc

Issue 1128043002: Fix more -Werror=sign-compare bugs with GCC 4.9.2 (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Rebase and fix new sign comparison errors Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/frame-elider.cc ('k') | test/unittests/counters-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/identity-map.cc
diff --git a/src/heap/identity-map.cc b/src/heap/identity-map.cc
index e968989f97f5ae5b9ab930bc772ae6ca793f75a9..9840d74a3c13a974ef8a2cc1abb5c94becfc8d93 100644
--- a/src/heap/identity-map.cc
+++ b/src/heap/identity-map.cc
@@ -38,7 +38,7 @@ IdentityMapBase::RawEntry IdentityMapBase::Insert(Handle<Object> key) {
int IdentityMapBase::Hash(Object* address) {
uintptr_t raw_address = reinterpret_cast<uintptr_t>(address);
- CHECK_NE(0, raw_address); // Cannot store Smi 0 as a key here, sorry.
+ CHECK_NE(0U, raw_address); // Cannot store Smi 0 as a key here, sorry.
// Xor some of the upper bits, since the lower 2 or 3 are usually aligned.
return static_cast<int>((raw_address >> 11) ^ raw_address);
}
« no previous file with comments | « src/compiler/frame-elider.cc ('k') | test/unittests/counters-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698