Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1128033002: Avoiding use of NOTIFICATION_EXTENSION_READY_DEPRECATED (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
CC:
chromium-reviews, Lei Zhang, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated NOTIFICATION_EXTENSION_READY_DEPRECATED from background_mode_manager.cc by use of ExtensionSystem::Get BUG=354046 Committed: https://crrev.com/5dd6bb023fc593463c7b28214873495a88116218 Cr-Commit-Position: refs/heads/master@{#329141}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed Review Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M chrome/browser/background/background_mode_manager.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 5 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-06 09:39:52 UTC) #2
Lei Zhang
Please ask a more local code owner from chrome/browser/background/OWNERS, instead of from chrome/OWNERS. https://codereview.chromium.org/1128033002/diff/1/chrome/browser/background/background_mode_manager.cc File ...
5 years, 7 months ago (2015-05-06 21:35:50 UTC) #4
Pranay
Fixed Review Comments https://codereview.chromium.org/1128033002/diff/1/chrome/browser/background/background_mode_manager.cc File chrome/browser/background/background_mode_manager.cc (left): https://codereview.chromium.org/1128033002/diff/1/chrome/browser/background/background_mode_manager.cc#oldcode389 chrome/browser/background/background_mode_manager.cc:389: // Extensions are loaded, so we ...
5 years, 7 months ago (2015-05-07 03:24:47 UTC) #5
Pranay
Hi Lei, Sure, will do the same about code owners review. Thanks for the review ...
5 years, 7 months ago (2015-05-07 03:31:19 UTC) #6
Pranay
PTAL
5 years, 7 months ago (2015-05-07 03:31:30 UTC) #7
Andrew T Wilson (Slow)
lgtm
5 years, 7 months ago (2015-05-11 10:07:53 UTC) #8
Pranay
Thanks!! :) -Pranay
5 years, 7 months ago (2015-05-11 10:09:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128033002/20001
5 years, 7 months ago (2015-05-11 10:09:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 11:02:51 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 11:03:46 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5dd6bb023fc593463c7b28214873495a88116218
Cr-Commit-Position: refs/heads/master@{#329141}

Powered by Google App Engine
This is Rietveld 408576698