Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 11280300: Revert 171011 - Broke Linux ChromiumOS Tests (dbg)(2) (Closed)

Created:
8 years ago by Ryan Sleevi
Modified:
8 years ago
Reviewers:
bshe
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, arv (Not doing code reviews), oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 171011 - Broke Linux ChromiumOS Tests (dbg)(2) Make wallpaper picker manifest and thumbnails available when offline. This CL did the following: 1. Save/update manifest in chrome.storage.local when user successfully requested latest manifest from server. If user failed to get manifest from server(offline or server error), fallback to the manifest saved in chrome.storage.local last time. 2. Lazily saves all requested thumbnails to thumbnails directory. And load from that directory when user open wallpaper picker next time. Note that thumbnails are shared across user session. So after one user saved thumbnails, all other users will directly use the thumbnails that saved in thumbnail directory. BUG=158668 Review URL: https://chromiumcodereview.appspot.com/11348215 TBR=bshe@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -402 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_private_api.h View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 7 chunks +34 lines, -174 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js View 1 chunk +8 lines, -25 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js View 4 chunks +11 lines, -28 lines 0 comments Download
M chrome/browser/resources/chromeos/wallpaper_manager/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_paths.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/wallpaper_private.json View 1 chunk +0 lines, -51 lines 0 comments Download
MM chrome/test/data/extensions/api_test/wallpaper_manager/test.js View 3 chunks +38 lines, -53 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ryan Sleevi
8 years ago (2012-12-04 21:15:20 UTC) #1
Ryan Sleevi
Failed build: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/6057 [ RUN ] ExtensionApiTest.WallpaperPicker [16705:16749:1204/122731:1441833427:ERROR:nss_util.cc(490)] Error initializing NSS with a persistent database ...
8 years ago (2012-12-04 21:15:54 UTC) #2
Ryan Sleevi
8 years ago (2012-12-04 21:17:11 UTC) #3
Message was sent while issue was closed.
Also
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...

[ RUN      ] ExtensionApiTest.WallpaperPicker
[19236:19236:1204/130047:1690924381:ERROR:zygote_host_impl_linux.cc(146)]
Running without the SUID sandbox! See
https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more
information on developing with the sandbox on.
[19236:19252:1204/130047:1691043804:ERROR:nss_util.cc(490)] Error initializing
NSS with a persistent database (sql:/etc/fake_root_ca/nssdb): NSS error code:
-8174
Xlib:  extension "GLX" missing on display ":9.0".
[19236:19236:1204/130047:1691055033:ERROR:gl_surface_glx.cc(378)]
glxQueryVersion failed
[19236:19236:1204/130047:1691055115:ERROR:gl_surface_linux.cc(58)]
GLSurfaceGLX::InitializeOneOff failed.
[19236:19236:1204/130047:1691055188:ERROR:compositor.cc(146)] Could not load the
GL bindings
[19236:19236:1204/130047:1691184908:ERROR:cros_user_policy_cache.cc(146)] Failed
to decode policy
Xlib:  extension "RANDR" missing on display ":9.0".
HTTP server started on 127.0.0.1:41928...
sending server_data: {"host": "127.0.0.1", "port": 41928} (36 bytes)
Corrupt JPEG data: 1183 extraneous bytes before marker 0x03
../../chrome/browser/chromeos/extensions/wallpaper_private_apitest.cc:11:
Failure
Value of: RunComponentExtensionTest("wallpaper_manager")
  Actual: false
Expected: true
Failed 1 of 5 tests
[  FAILED  ] ExtensionApiTest.WallpaperPicker, where TypeParam =  and GetParam()
=  (1998 ms)

Powered by Google App Engine
This is Rietveld 408576698