Issue 11280296: Refactor extension.cc to match ordering of extension.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280296: Refactor extension.cc to match ordering of extension.h. (Closed)

Created:
8 years ago by scheib

Modified:
8 years ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor extension.cc to match ordering of extension.h. BUG=164184 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171041

Patch Set 1 #

Patch Set 2 : // static added to some missing members. #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2876 lines, -2872 lines)			Patch
	M	chrome/common/extensions/extension.cc	View	1	9 chunks	+2876 lines, -2872 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/11280296/5001

8 years ago (2012-12-04 18:49:27 UTC) #3

commit-bot: I haz the power

8 years ago (2012-12-04 18:49:35 UTC) #4

Presubmit check for 11280296-5001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    chrome/common/extensions/extension.cc:1403

Presubmit checks took 2.6s to calculate.

Expand Messages | Collapse Messages