Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4179)

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 11280287: Magnifier: Prevent useless operation in enabling/disabling magnifier. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fix test failure (MagnificationManagerTest.ChangeMagnifierType) Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index 2e3799a7d0c71136a7b669e8657e7d98cf0306ed..8e970feb5bcbd100a6172846a928f64b6ff5e03f 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -472,6 +472,10 @@ void ChromeBrowserMainPartsChromeos::PreProfileInit() {
new default_app_order::ExternalLoader(true /* async */));
}
+ // Initialize magnification manager before ash tray is created. And this must
+ // be placed after UserManager::SessionStarted();
+ chromeos::MagnificationManager::Initialize();
+
// In Aura builds this will initialize ash::Shell.
ChromeBrowserMainPartsLinux::PreProfileInit();
}
@@ -527,8 +531,6 @@ void ChromeBrowserMainPartsChromeos::PostProfileInit() {
power_state_override_ = new PowerStateOverride(
PowerStateOverride::BLOCK_DISPLAY_SLEEP);
}
- magnification_manager_.reset(
- chromeos::MagnificationManager::CreateInstance());
chromeos::accessibility::Initialize();
primary_display_switch_observer_.reset(
@@ -627,7 +629,6 @@ void ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() {
resume_observer_.reset();
brightness_observer_.reset();
output_observer_.reset();
- magnification_manager_.reset();
power_state_override_ = NULL;
// The XInput2 event listener needs to be shut down earlier than when
@@ -655,6 +656,8 @@ void ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() {
// Delete ContactManager while |g_browser_process| is still alive.
contact_manager_.reset();
+ chromeos::MagnificationManager::Shutdown();
+
// Let the UserManager unregister itself as an observer of the CrosSettings
// singleton before it is destroyed.
UserManager::Get()->Shutdown();
« no previous file with comments | « chrome/browser/chromeos/chrome_browser_main_chromeos.h ('k') | chrome/browser/chromeos/system/ash_system_tray_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698