content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java - Issue 11280284: onShowCustomView

Unified Diff: content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

Issue 11280284: onShowCustomView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: actually using it .... Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« android_webview/java/src/org/chromium/android_webview/AwResource.java ('K') | « android_webview/java/src/org/chromium/android_webview/AwResource.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

diff --git a/content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java b/content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

index a4614cb40f64f4e3ebcbb4d973f4f8c69d62e3e5..bafadd095ed58e4d68c7247ee5cdef06342e59a0 100644

--- a/content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

+++ b/content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

@@ -6,6 +6,7 @@ package org.chromium.content.components.web_contents_delegate_android;

import android.graphics.Rect;

import android.view.KeyEvent;

+import android.view.View;

import org.chromium.base.CalledByNative;

import org.chromium.base.JNINamespace;

@@ -73,6 +74,13 @@ public class WebContentsDelegateAndroid {

public void onLoadProgressChanged(int progress) {

}

+ /**

+ * Notifies the client that the renderer has a custom view for us.

+ * The only case now is when a video wants to go full screen.

+ */

+ public void onShowCustomView(View view) {

joth 2012/12/08 00:17:58 You dont' need this, the new class you add calls s

acleung 2013/01/07 23:40:03 Done.

joth 2013/02/06 00:02:29 Are you sure? I still see this file edited in the

acleung1 2013/02/12 18:45:32 Not sure what happend. I reverted the file now.

+ }

@CalledByNative

public void onUpdateUrl(String url) {

}