Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2044)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 11280284: onShowCustomView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: actually using it .... Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
index 02eaa25639765222a9d0c34a9ae67a17eab80272..7d51363eb99d274d2b2cc8c01679cb99692dcce3 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
@@ -11,6 +11,7 @@ import android.os.Looper;
import android.os.Message;
import android.util.Log;
import android.view.KeyEvent;
+import android.view.View;
import android.webkit.ConsoleMessage;
import org.chromium.content.browser.ContentViewClient;
@@ -139,6 +140,11 @@ public abstract class AwContentsClient extends ContentViewClient {
}
@Override
+ public void onShowCustomView(View view) {
joth 2012/12/08 00:17:58 not needed?
acleung 2013/01/07 23:40:03 Done.
+ AwContentsClient.this.onShowCustomView(view);
+ }
+
+ @Override
public boolean addNewContents(boolean isDialog, boolean isUserGesture) {
return AwContentsClient.this.onCreateWindow(isDialog, isUserGesture);
}
@@ -233,6 +239,8 @@ public abstract class AwContentsClient extends ContentViewClient {
public abstract void onReceivedError(int errorCode, String description, String failingUrl);
+ public abstract void onShowCustomView(View view);
+
//--------------------------------------------------------------------------------------------
// Stuff that we ignore since it only makes sense for Chrome browser
//--------------------------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698