cc: Temporary diagnostics.

cc: Temporary diagnostics.

BUG=160485
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172375

[reveman, 2012-12-03 12:46:32]

This adds some temporary diagnostic checks that I hope will help track down:
https://code.google.com/p/chromium/issues/detail?id=160485

[enne (OOO), 2012-12-04 00:57:02]

I'm happy to review this, but I don't follow what case you're trying to suss out
here.  Are you assuming that somebody is calling reset() outside of
setTilingData and the layer dtor? (And, if so, why would that be problematic?)

https://codereview.chromium.org/11280274/diff/1/cc/tiled_layer_impl.cc
File cc/tiled_layer_impl.cc (right):

https://codereview.chromium.org/11280274/diff/1/cc/tiled_layer_impl.cc#newcod...
cc/tiled_layer_impl.cc:106: CHECK(addedTile);
I've added these checks in the past and never gotten anything from them.  :(

[reveman, 2012-12-06 21:52:22]

I suspect that m_tiled is used without being initialized or that one of the
tiles are destroyed outside of m_tiler. I can't see how any of that would happen
but this is the best I could think of.

These crashes are much more common on ARM where the gpu crash rate is 7-8X
higher and I suspect that there might be a correlation between the two.

[enne (OOO), 2012-12-11 17:21:20]

lgtm.  Sorry for letting this bug languish for so long.

[commit-bot: I haz the power, 2012-12-11 17:34:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/11280274/1

[commit-bot: I haz the power, 2012-12-11 19:42:30]

Change committed as 172375