Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 11280268: Merge 170403 - Use a lock to deal with concurrent access to the m_evictedBackings (Closed)

Created:
8 years ago by ccameron
Modified:
8 years ago
Reviewers:
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Merge 170403 - Use a lock to deal with concurrent access to the m_evictedBackings Use a mutex to deal with concurrent access to the m_evictedBackings list, instead of passing the list of pointers around. In ThreadProxy::beginFrame, we unlink all evicted textures, so that the call to updateLayers will know to re-paint the evicted layers. In ThreadProxy::scheduleActionCommit, we determine if we can draw now by checking to see if there exist any linked evicted textures. If there are none, we can draw what we are in the process of committing. This assumes that once we get to m_layerTreeHost->willBeginFrame() in ThreadProxy::beginFrame, the next frame to be commited by ThreadProxy::scheduleActionCommit be at or after the frame that is being produced by that call to ThreadProxy::beginFrame. BUG=158747 TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -60 lines) Patch
M cc/prioritized_texture_manager.h View 4 chunks +12 lines, -7 lines 0 comments Download
M cc/prioritized_texture_manager.cc View 5 chunks +10 lines, -33 lines 0 comments Download
M cc/prioritized_texture_unittest.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M cc/single_thread_proxy.cc View 1 chunk +1 line, -6 lines 0 comments Download
M cc/thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/thread_proxy.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/tiled_layer_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698