Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: cc/layer_unittest.cc

Issue 11280263: Organize internal properties of cc/ layer types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed all feedback so far Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layer_unittest.cc
diff --git a/cc/layer_unittest.cc b/cc/layer_unittest.cc
index 6056a945e90ce37022595d1979e715625cffe30a..52676591565b502fe84f0da59e153378052e53ea 100644
--- a/cc/layer_unittest.cc
+++ b/cc/layer_unittest.cc
@@ -512,16 +512,6 @@ TEST_F(LayerTest, checkPropertyChangeCausesCorrectBehavior)
// sanity check of initial test condition
EXPECT_FALSE(testLayer->needsDisplay());
- // Test properties that should not call needsDisplay and needsCommit when changed.
- EXPECT_SET_NEEDS_COMMIT(0, testLayer->setVisibleContentRect(gfx::Rect(0, 0, 40, 50)));
- EXPECT_SET_NEEDS_COMMIT(0, testLayer->setUseLCDText(true));
- EXPECT_SET_NEEDS_COMMIT(0, testLayer->setDrawOpacity(0.5));
- EXPECT_SET_NEEDS_COMMIT(0, testLayer->setRenderTarget(0));
- EXPECT_SET_NEEDS_COMMIT(0, testLayer->setDrawTransform(gfx::Transform()));
- EXPECT_SET_NEEDS_COMMIT(0, testLayer->setScreenSpaceTransform(gfx::Transform()));
- EXPECT_SET_NEEDS_COMMIT(0, testLayer->setDrawableContentRect(gfx::Rect(4, 5, 6, 7)));
- EXPECT_FALSE(testLayer->needsDisplay());
-
// Next, test properties that should call setNeedsCommit (but not setNeedsDisplay)
// All properties need to be set to new values in order for setNeedsCommit to be called.
EXPECT_SET_NEEDS_COMMIT(1, testLayer->setAnchorPoint(gfx::PointF(1.23f, 4.56f)));

Powered by Google App Engine
This is Rietveld 408576698