Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: cc/layer_impl.cc

Issue 11280263: Organize internal properties of cc/ layer types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/layer_impl.h ('K') | « cc/layer_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layer_impl.cc
diff --git a/cc/layer_impl.cc b/cc/layer_impl.cc
index a1dffea69f549bbdd673c81d5076b54092677f23..135623fc93005ed4717b5346df5bc297d038823b 100644
--- a/cc/layer_impl.cc
+++ b/cc/layer_impl.cc
@@ -20,6 +20,7 @@
namespace cc {
+
LayerImpl::LayerImpl(int id)
: m_parent(0)
, m_maskLayerId(-1)
@@ -48,14 +49,8 @@ LayerImpl::LayerImpl(int id)
, m_forceRenderSurface(false)
, m_isContainerForFixedPositionLayers(false)
, m_fixedToContainerLayer(false)
- , m_renderTarget(0)
, m_drawDepth(0)
- , m_drawOpacity(0)
- , m_drawOpacityIsAnimating(false)
, m_filter(0)
- , m_drawTransformIsAnimating(false)
- , m_screenSpaceTransformIsAnimating(false)
- , m_isClipped(false)
#ifndef NDEBUG
, m_betweenWillDrawAndDidDraw(false)
#endif
@@ -128,7 +123,7 @@ int LayerImpl::descendantsDrawContent()
scoped_ptr<SharedQuadState> LayerImpl::createSharedQuadState() const
{
scoped_ptr<SharedQuadState> state = SharedQuadState::Create();
- state->SetAll(m_drawTransform, m_visibleContentRect, m_drawableContentRect, m_clipRect, m_isClipped, m_drawOpacity);
+ state->SetAll(m_drawProperties.drawTransform, m_drawProperties.visibleContentRect, m_drawProperties.drawableContentRect, m_drawProperties.clipRect, m_drawProperties.isClipped, m_drawProperties.drawOpacity);
return state.Pass();
}
@@ -297,9 +292,9 @@ void LayerImpl::dumpLayerProperties(std::string* str, int indent) const
str->append(indentStr);
base::StringAppendF(str, "bounds: %d, %d\n", bounds().width(), bounds().height());
- if (m_renderTarget) {
+ if (m_drawProperties.renderTarget) {
str->append(indentStr);
- base::StringAppendF(str, "renderTarget: %d\n", m_renderTarget->m_layerId);
+ base::StringAppendF(str, "renderTarget: %d\n", m_drawProperties.renderTarget->m_layerId);
}
str->append(indentStr);
@@ -309,11 +304,12 @@ void LayerImpl::dumpLayerProperties(std::string* str, int indent) const
base::StringAppendF(str, "contentsOpaque: %d\n", m_contentsOpaque);
str->append(indentStr);
+ const gfx::Transform& transform = m_drawProperties.drawTransform;
base::StringAppendF(str, "drawTransform: %f, %f, %f, %f // %f, %f, %f, %f // %f, %f, %f, %f // %f, %f, %f, %f\n",
- m_drawTransform.matrix().getDouble(0, 0), m_drawTransform.matrix().getDouble(0, 1), m_drawTransform.matrix().getDouble(0, 2), m_drawTransform.matrix().getDouble(0, 3),
- m_drawTransform.matrix().getDouble(1, 0), m_drawTransform.matrix().getDouble(1, 1), m_drawTransform.matrix().getDouble(1, 2), m_drawTransform.matrix().getDouble(1, 3),
- m_drawTransform.matrix().getDouble(2, 0), m_drawTransform.matrix().getDouble(2, 1), m_drawTransform.matrix().getDouble(2, 2), m_drawTransform.matrix().getDouble(2, 3),
- m_drawTransform.matrix().getDouble(3, 0), m_drawTransform.matrix().getDouble(3, 1), m_drawTransform.matrix().getDouble(3, 2), m_drawTransform.matrix().getDouble(3, 3));
+ transform.matrix().getDouble(0, 0), transform.matrix().getDouble(0, 1), transform.matrix().getDouble(0, 2), transform.matrix().getDouble(0, 3),
+ transform.matrix().getDouble(1, 0), transform.matrix().getDouble(1, 1), transform.matrix().getDouble(1, 2), transform.matrix().getDouble(1, 3),
+ transform.matrix().getDouble(2, 0), transform.matrix().getDouble(2, 1), transform.matrix().getDouble(2, 2), transform.matrix().getDouble(2, 3),
+ transform.matrix().getDouble(3, 0), transform.matrix().getDouble(3, 1), transform.matrix().getDouble(3, 2), transform.matrix().getDouble(3, 3));
str->append(indentStr);
base::StringAppendF(str, "drawsContent: %s\n", m_drawsContent ? "yes" : "no");
« cc/layer_impl.h ('K') | « cc/layer_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698