Fixing column widths in tables.

chrome/browser/resources/shared/js/cr/ui/list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: array_data_model.js
 // require: list_selection_model.js
 // require: list_selection_controller.js
 // require: list_item.js
 
 /**
@@ skipping 328 matching lines @@
       this.nextUniqueIdSuffix_ = 0;
     },
 
     /**
      * @param {ListItem=} item The list item to measure.
      * @return {number} The height of the given item. If the fixed height on CSS
      * is set by 'px', uses that value as height. Otherwise, measures the size.
      * @private
      */
     measureItemHeight_: function(item) {
-      var height = item.style.height;
-      // Use the fixed height if set it on CSS, to save a time of layout
-      // calculation.
-      if (height && height.substr(-2) == 'px')

[SeRya, 2012/11/30 13:20:01]

This code ignored item margins.

-        return parseInt(height.substr(0, height.length - 2));
-
       return this.measureItem(item).height;
     },
 
     /**
      * @return {number} The height of default item, measuring it if necessary.
      * @private
      */
     getDefaultItemHeight_: function() {
       return this.getDefaultItemSize_().height;
     },
 
     /**
      * @param {number} index The index of the item.
      * @return {number} The height of the item, measuring it if necessary.
      */
     getItemHeightByIndex_: function(index) {
       // If |this.fixedHeight_| is true, all the rows have same default height.
       if (this.fixedHeight_)
         return this.getDefaultItemHeight_();
 
       if (this.cachedItemHeights_[index])
         return this.cachedItemHeights_[index];
 
       var item = this.getListItemByIndex(index);
-      if (item)
-        return this.measureItemHeight_(item);
-
+      if (item) {
+        var h = this.measureItemHeight_(item);
+        this.cachedItemHeights_[index] = h;
+        return h;
+      }
       return this.getDefaultItemHeight_();
     },
 
     /**
      * @return {{height: number, width: number}} The height and width
      *     of default item, measuring it if necessary.
      * @private
      */
     getDefaultItemSize_: function() {
       if (!this.measured_ || !this.measured_.height) {
@@ skipping 289 matching lines @@
 
     /**
      * @param {number} index The index of the item.
      * @return {number} The top position of the item inside the list.
      */
     getItemTop: function(index) {
       if (this.fixedHeight_) {
         var itemHeight = this.getDefaultItemHeight_();
         return index * itemHeight;
       } else {
+        this.ensureAllItemSizesInCache();
         var top = 0;
         for (var i = 0; i < index; i++) {
           top += this.getItemHeightByIndex_(i);
         }
         return top;
       }
     },
 
     /**
      * @param {number} index The index of the item.
@@ skipping 345 matching lines @@
       for (var y = 0; y < measuringIndexes.length; y++) {
         // If the list item has been appended above, removes it.
         if (isElementAppended[y])
           this.removeChild(measuringItems[y]);
       }
     },
 
     /**
      * Returns the height of after filler in the list.
      * @param {number} lastIndex The index of item past the last in viewport.
-     * @param {number} itemHeight The height of the item.
      * @return {number} The height of after filler.
      */
     getAfterFillerHeight: function(lastIndex) {
       if (this.fixedHeight_) {
         var itemHeight = this.getDefaultItemHeight_();
         return (this.dataModel.length - lastIndex) * itemHeight;
       }
 
       var height = 0;
       for (var i = lastIndex; i < this.dataModel.length; i++)
         height += this.getItemHeightByIndex_(i);
       return height;
     },
 
     /**
      * Redraws the viewport.
      */
     redraw: function() {
       if (this.batchCount_ != 0)
         return;
 
       var dataModel = this.dataModel;
       if (!dataModel || !this.autoExpands_ && this.clientHeight == 0) {
         this.cachedItems_ = {};
         this.firstIndex_ = 0;
         this.lastIndex_ = 0;
-        this.remainingSpace_ = true;
+        this.remainingSpace_ = this.clientHeight != 0;
         this.mergeItems(0, 0, {}, {});
         return;
       }
 
       // Save the previous positions before any manipulation of elements.
       var scrollTop = this.scrollTop;
       var clientHeight = this.clientHeight;
 
       // Store all the item sizes into the cache in advance, to prevent
       // interleave measuring with mutating dom.
@@ skipping 178 matching lines @@
    * because list items can contain controls that can be focused, and for some
    * purposes (e.g., styling), the list can still be conceptually focused at
    * that point even though it doesn't actually have the page focus.
    */
   cr.defineProperty(List, 'hasElementFocus', cr.PropertyKind.BOOL_ATTR);
 
   return {
     List: List
   };
 });