Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Issue 11280251: chrome: Use skia::RefPtr for skia ref-counted objects. (Closed)

Created:
8 years ago by danakj
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, dcheng, darin-cc_chromium.org, sail+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, piman, backer, Ryan Sleevi
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebased #

Patch Set 4 : rebaseD #

Patch Set 5 : winbuild #

Patch Set 6 : linuxbuild #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -47 lines) Patch
M chrome/browser/chromeos/login/rounded_rect_painter.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_container_gtk.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/omnibox/location_bar_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_background.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_view.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/theme_helpers.cc View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/badge_util.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_thumbnailer.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
Once ui/ is converted this removes any manual reference counting in chrome/
8 years ago (2012-11-30 02:25:51 UTC) #1
sky
LGTM
8 years ago (2012-12-03 15:30:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11280251/10001
8 years ago (2012-12-05 22:26:24 UTC) #3
commit-bot: I haz the power
Change committed as 171333
8 years ago (2012-12-05 22:28:02 UTC) #4
danakj
8 years ago (2012-12-06 02:51:49 UTC) #5
Running interactive_ui_tests:PanelDragBrowserTest.CloseDetachedPanelOnDrag
locally on linux under valgrind doesn't turn up any problems.

Powered by Google App Engine
This is Rietveld 408576698