Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1128023008: [Smart Lock] Update chrome://settings UI (Closed)

Created:
5 years, 7 months ago by Garrett Casto
Modified:
5 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Update strings in chrome://settings BUG=486739 Committed: https://crrev.com/72359feca2962c9f3cda3cd6989d0c922cc8d15f Cr-Commit-Position: refs/heads/master@{#330216}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Garrett Casto
Screenshot at crbug.com/486739#c29
5 years, 7 months ago (2015-05-15 19:02:58 UTC) #2
Evan Stade
lgtm
5 years, 7 months ago (2015-05-15 19:15:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128023008/20001
5 years, 7 months ago (2015-05-15 20:48:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 22:24:18 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:28:26 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72359feca2962c9f3cda3cd6989d0c922cc8d15f
Cr-Commit-Position: refs/heads/master@{#330216}

Powered by Google App Engine
This is Rietveld 408576698