Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1128023006: Files.app: Expand paddings of breadcrumbs. (Closed)

Created:
5 years, 7 months ago by fukino
Modified:
5 years, 7 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Expand padding of breadcrumbs. This CL expands padding of breadcrumbs from 5px to 9px. Along with it, some padding are reduced to keep the overall layout. BUG=480720 TEST=manually Committed: https://crrev.com/f65f6d7767a2a44c5b42f82db9e56f9a67816359 Cr-Commit-Position: refs/heads/master@{#330054}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
PTAL. Thanks!
5 years, 7 months ago (2015-05-15 03:53:15 UTC) #2
yawano
lgtm. Thank you!
5 years, 7 months ago (2015-05-15 04:49:00 UTC) #3
fukino
On 2015/05/15 04:49:00, yawano wrote: > lgtm. Thank you! Thanks!
5 years, 7 months ago (2015-05-15 06:20:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128023006/20001
5 years, 7 months ago (2015-05-15 06:21:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 06:48:51 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 06:49:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f65f6d7767a2a44c5b42f82db9e56f9a67816359
Cr-Commit-Position: refs/heads/master@{#330054}

Powered by Google App Engine
This is Rietveld 408576698