Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1128023005: Remove static logging of memory allocations (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove static logging of memory allocations We want to move to a world where there's no Isolate::Current but we always knows which isolate we're in. There's no way we can teach this info to the C++ allocator. BUG=none R=hpayer@chromium.org LOG=n Committed: https://crrev.com/6dd52eaf4784b06af060bf054e07968e45937cdf Cr-Commit-Position: refs/heads/master@{#28414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -50 lines) Patch
M src/globals.h View 1 chunk +0 lines, -20 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +0 lines, -15 lines 0 comments Download
M src/log.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/log.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-15 00:55:05 UTC) #1
Hannes Payer (out of office)
Is nobody using that anymore? If that is the case, LGTM.
5 years, 7 months ago (2015-05-15 07:07:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128023005/1
5 years, 7 months ago (2015-05-15 07:35:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 07:37:21 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 07:37:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dd52eaf4784b06af060bf054e07968e45937cdf
Cr-Commit-Position: refs/heads/master@{#28414}

Powered by Google App Engine
This is Rietveld 408576698