Media Router: Replace drop-down-button with core-icon-button.

Media Router: Replace drop-down-button with core-icon-button.

- Removes drop-down-button custom polymer element.
- Removes Media Router drop-down icons.
- Replace drop-down-button with core-icon-button.

Committed: https://crrev.com/1de7ddc822db43235df2f68487a1c30ab2a925e0
Cr-Commit-Position: refs/heads/master@{#329985}

[apacible, 2015-05-08 02:53:53]

Patchset #1 (id:1) has been deleted

[apacible, 2015-05-08 02:56:07]

Patchset #1 (id:20001) has been deleted

[apacible, 2015-05-08 03:03:11]

apacible@chromium.org changed reviewers:
+ jhawkins@chromium.org, jlklein@chromium.org, mfoltz@chromium.org,
michaelpg@chromium.org

[apacible, 2015-05-08 03:07:48]

Patchset #1 (id:40001) has been deleted

[apacible, 2015-05-08 03:16:58]

PTAL, thanks!

We're working to replace parts/some of our custom elements with core elements,
as well as iterating on the design.

Screenshots:
No Cast Mode List Showing:
LTR: https://screenshot.googleplex.com/SUdPi8h7nB4.png
RTL: https://screenshot.googleplex.com/u103DhGQpxe.png

Cast Mode List Showing:
LTR: https://screenshot.googleplex.com/OFafNWscSCC.png
RTL: https://screenshot.googleplex.com/qqdmGS4j0gL.png

Hover:
LTR: https://screenshot.googleplex.com/TcRmJ54KxVN.png
RTL: https://screenshot.googleplex.com/w5ZH1gyysmt.png

[Jeremy Klein, 2015-05-08 04:59:48]

Generally looks good. I'm curious if you could use cr-expand-button which is
sort of similar to what you're doing here:

https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...

Also would it make sense later to make the mode menu into a paper-menu-button?

[apacible, 2015-05-08 16:46:10]

On 2015/05/08 04:59:48, Jeremy Klein wrote:
> Generally looks good. I'm curious if you could use cr-expand-button which is
> sort of similar to what you're doing here:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...
> 
> Also would it make sense later to make the mode menu into a paper-menu-button?

Thanks for the suggestion! I sent some screenshots of what it would look like
with cr-expand-button to our UX designer for feedback. I'll update this CL when
I hear back from him.

I'll messaging you offline about the mode menu.

[mark a. foltz, 2015-05-09 06:04:42]

Looks good, but seems to be pending feedback from UX.

https://codereview.chromium.org/1128023003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(right):

https://codereview.chromium.org/1128023003/diff/60001/chrome/browser/resource...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:3:
<link rel="import" href="chrome://resources/polymer/core-icons/core-icons.html">
I don't see a <core-icon> element referenced below.  Is this import necessary?

[apacible, 2015-05-12 18:21:30]

Patchset #2 (id:80001) has been deleted

[apacible, 2015-05-12 18:25:20]

Per conversation with our UX designer:

cr-expand-button is used specifically for expand/collapse list control. Since we
want a button to toggle between the two lists, the core/paper-icon-button would
better serve our needs.

I switched core-icon-button to paper-icon-button for the material feel.

https://codereview.chromium.org/1128023003/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(right):

https://codereview.chromium.org/1128023003/diff/60001/chrome/browser/resource...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:3:
<link rel="import" href="chrome://resources/polymer/core-icons/core-icons.html">
On 2015/05/09 06:04:42, mark a. foltz wrote:
> I don't see a <core-icon> element referenced below.  Is this import necessary?

Removed.

[apacible, 2015-05-12 18:31:12]

Patchset #3 (id:120001) has been deleted

[Jeremy Klein, 2015-05-13 00:08:01]

lgtm

[mark a. foltz, 2015-05-13 01:53:52]

https://codereview.chromium.org/1128023003/diff/140001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(right):

https://codereview.chromium.org/1128023003/diff/140001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:22:
icon="{{ {castModeHidden: castModeHidden_} | getDropDownIcon}}">
Similar comment from other patch about using currentView_ vs castModeHidden_

[apacible, 2015-05-14 21:10:41]

https://codereview.chromium.org/1128023003/diff/140001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(right):

https://codereview.chromium.org/1128023003/diff/140001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:22:
icon="{{ {castModeHidden: castModeHidden_} | getDropDownIcon}}">
On 2015/05/13 01:53:52, mark a. foltz wrote:
> Similar comment from other patch about using currentView_ vs castModeHidden_

Talked offline, will keep this as is. Filters will be removed in upcoming patch
to update elements to 0.8.

[mark a. foltz, 2015-05-14 22:43:55]

lgtm

[apacible, 2015-05-14 23:19:26]

Patchset #4 (id:160001) has been deleted

[apacible, 2015-05-14 23:19:30]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2015-05-14 23:21:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128023003/140001

[commit-bot: I haz the power, 2015-05-15 00:09:21]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2015-05-15 00:11:15]

Patchset 3 (id:??) landed as
https://crrev.com/1de7ddc822db43235df2f68487a1c30ab2a925e0
Cr-Commit-Position: refs/heads/master@{#329985}