Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4092)

Unified Diff: chrome/browser/ui/gtk/extensions/app_window_gtk.cc

Issue 11280173: Rename ShellWindow* classes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix mac build Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/extensions/app_window_gtk.cc
diff --git a/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc b/chrome/browser/ui/gtk/extensions/app_window_gtk.cc
similarity index 83%
rename from chrome/browser/ui/gtk/extensions/shell_window_gtk.cc
rename to chrome/browser/ui/gtk/extensions/app_window_gtk.cc
index 32e7c73c4abadf0df0a98560c0095a26ea7bd0b8..a5230fb50e94c9eb18aa48abb8aba5909403cac0 100644
--- a/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc
+++ b/chrome/browser/ui/gtk/extensions/app_window_gtk.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ui/gtk/extensions/shell_window_gtk.h"
+#include "chrome/browser/ui/gtk/extensions/app_window_gtk.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/profiles/profile.h"
@@ -27,8 +27,8 @@ const int kDebounceTimeoutMilliseconds = 100;
} // namespace
-ShellWindowGtk::ShellWindowGtk(ShellWindow* shell_window,
- const ShellWindow::CreateParams& params)
+AppWindowGtk::AppWindowGtk(ShellWindow* shell_window,
+ const ShellWindow::CreateParams& params)
: shell_window_(shell_window),
window_(NULL),
state_(GDK_WINDOW_STATE_WITHDRAWN),
@@ -123,11 +123,11 @@ ShellWindowGtk::ShellWindowGtk(ShellWindow* shell_window,
ui::ActiveWindowWatcherX::AddObserver(this);
}
-ShellWindowGtk::~ShellWindowGtk() {
+AppWindowGtk::~AppWindowGtk() {
ui::ActiveWindowWatcherX::RemoveObserver(this);
}
-bool ShellWindowGtk::IsActive() const {
+bool AppWindowGtk::IsActive() const {
if (ui::ActiveWindowWatcherX::WMSupportsActivation())
return is_active_;
@@ -135,44 +135,44 @@ bool ShellWindowGtk::IsActive() const {
return gtk_window_is_active(window_);
}
-bool ShellWindowGtk::IsMaximized() const {
+bool AppWindowGtk::IsMaximized() const {
return (state_ & GDK_WINDOW_STATE_MAXIMIZED);
}
-bool ShellWindowGtk::IsMinimized() const {
+bool AppWindowGtk::IsMinimized() const {
return (state_ & GDK_WINDOW_STATE_ICONIFIED);
}
-bool ShellWindowGtk::IsFullscreen() const {
+bool AppWindowGtk::IsFullscreen() const {
return false;
}
-gfx::NativeWindow ShellWindowGtk::GetNativeWindow() {
+gfx::NativeWindow AppWindowGtk::GetNativeWindow() {
return window_;
}
-gfx::Rect ShellWindowGtk::GetRestoredBounds() const {
+gfx::Rect AppWindowGtk::GetRestoredBounds() const {
return restored_bounds_;
}
-gfx::Rect ShellWindowGtk::GetBounds() const {
+gfx::Rect AppWindowGtk::GetBounds() const {
return bounds_;
}
-void ShellWindowGtk::Show() {
+void AppWindowGtk::Show() {
gtk_window_present(window_);
}
-void ShellWindowGtk::ShowInactive() {
+void AppWindowGtk::ShowInactive() {
gtk_window_set_focus_on_map(window_, false);
gtk_widget_show(GTK_WIDGET(window_));
}
-void ShellWindowGtk::Hide() {
+void AppWindowGtk::Hide() {
gtk_widget_hide(GTK_WIDGET(window_));
}
-void ShellWindowGtk::Close() {
+void AppWindowGtk::Close() {
shell_window_->SaveWindowPosition();
// Cancel any pending callback from the window configure debounce timer.
@@ -190,44 +190,44 @@ void ShellWindowGtk::Close() {
gtk_widget_destroy(window);
}
-void ShellWindowGtk::Activate() {
+void AppWindowGtk::Activate() {
gtk_window_present(window_);
}
-void ShellWindowGtk::Deactivate() {
+void AppWindowGtk::Deactivate() {
gdk_window_lower(gtk_widget_get_window(GTK_WIDGET(window_)));
}
-void ShellWindowGtk::Maximize() {
+void AppWindowGtk::Maximize() {
gtk_window_maximize(window_);
}
-void ShellWindowGtk::Minimize() {
+void AppWindowGtk::Minimize() {
gtk_window_iconify(window_);
}
-void ShellWindowGtk::Restore() {
+void AppWindowGtk::Restore() {
if (IsMaximized())
gtk_window_unmaximize(window_);
else if (IsMinimized())
gtk_window_deiconify(window_);
}
-void ShellWindowGtk::SetBounds(const gfx::Rect& bounds) {
+void AppWindowGtk::SetBounds(const gfx::Rect& bounds) {
gtk_window_move(window_, bounds.x(), bounds.y());
gtk_window_util::SetWindowSize(window_,
gfx::Size(bounds.width(), bounds.height()));
}
-void ShellWindowGtk::FlashFrame(bool flash) {
+void AppWindowGtk::FlashFrame(bool flash) {
gtk_window_set_urgency_hint(window_, flash);
}
-bool ShellWindowGtk::IsAlwaysOnTop() const {
+bool AppWindowGtk::IsAlwaysOnTop() const {
return false;
}
-void ShellWindowGtk::ActiveWindowChanged(GdkWindow* active_window) {
+void AppWindowGtk::ActiveWindowChanged(GdkWindow* active_window) {
// Do nothing if we're in the process of closing the browser window.
if (!window_)
return;
@@ -237,8 +237,8 @@ void ShellWindowGtk::ActiveWindowChanged(GdkWindow* active_window) {
// Callback for the delete event. This event is fired when the user tries to
// close the window (e.g., clicking on the X in the window manager title bar).
-gboolean ShellWindowGtk::OnMainWindowDeleteEvent(GtkWidget* widget,
- GdkEvent* event) {
+gboolean AppWindowGtk::OnMainWindowDeleteEvent(GtkWidget* widget,
+ GdkEvent* event) {
Close();
// Return true to prevent the GTK window from being destroyed. Close will
@@ -246,8 +246,8 @@ gboolean ShellWindowGtk::OnMainWindowDeleteEvent(GtkWidget* widget,
return TRUE;
}
-gboolean ShellWindowGtk::OnConfigure(GtkWidget* widget,
- GdkEventConfigure* event) {
+gboolean AppWindowGtk::OnConfigure(GtkWidget* widget,
+ GdkEventConfigure* event) {
// We update |bounds_| but not |restored_bounds_| here. The latter needs
// to be updated conditionally when the window is non-maximized and non-
// fullscreen, but whether those state updates have been processed yet is
@@ -268,18 +268,18 @@ gboolean ShellWindowGtk::OnConfigure(GtkWidget* widget,
window_configure_debounce_timer_.Stop();
window_configure_debounce_timer_.Start(FROM_HERE,
base::TimeDelta::FromMilliseconds(kDebounceTimeoutMilliseconds), this,
- &ShellWindowGtk::OnDebouncedBoundsChanged);
+ &AppWindowGtk::OnDebouncedBoundsChanged);
return FALSE;
}
-void ShellWindowGtk::OnDebouncedBoundsChanged() {
+void AppWindowGtk::OnDebouncedBoundsChanged() {
gtk_window_util::UpdateWindowPosition(this, &bounds_, &restored_bounds_);
shell_window_->SaveWindowPosition();
}
-gboolean ShellWindowGtk::OnWindowState(GtkWidget* sender,
- GdkEventWindowState* event) {
+gboolean AppWindowGtk::OnWindowState(GtkWidget* sender,
+ GdkEventWindowState* event) {
state_ = event->new_window_state;
if (content_thinks_its_fullscreen_ &&
@@ -293,8 +293,8 @@ gboolean ShellWindowGtk::OnWindowState(GtkWidget* sender,
return FALSE;
}
-gboolean ShellWindowGtk::OnButtonPress(GtkWidget* widget,
- GdkEventButton* event) {
+gboolean AppWindowGtk::OnButtonPress(GtkWidget* widget,
+ GdkEventButton* event) {
if (draggable_region_ && draggable_region_->contains(event->x, event->y)) {
if (event->button == 1) {
if (GDK_BUTTON_PRESS == event->type) {
@@ -323,7 +323,7 @@ gboolean ShellWindowGtk::OnButtonPress(GtkWidget* widget,
return FALSE;
}
-void ShellWindowGtk::SetFullscreen(bool fullscreen) {
+void AppWindowGtk::SetFullscreen(bool fullscreen) {
content_thinks_its_fullscreen_ = fullscreen;
if (fullscreen)
gtk_window_fullscreen(window_);
@@ -331,11 +331,11 @@ void ShellWindowGtk::SetFullscreen(bool fullscreen) {
gtk_window_unfullscreen(window_);
}
-bool ShellWindowGtk::IsFullscreenOrPending() const {
+bool AppWindowGtk::IsFullscreenOrPending() const {
return content_thinks_its_fullscreen_;
}
-void ShellWindowGtk::UpdateWindowIcon() {
+void AppWindowGtk::UpdateWindowIcon() {
Profile* profile = shell_window_->profile();
gfx::Image app_icon = shell_window_->app_icon();
if (!app_icon.IsEmpty())
@@ -344,17 +344,17 @@ void ShellWindowGtk::UpdateWindowIcon() {
gtk_util::SetWindowIcon(window_, profile);
}
-void ShellWindowGtk::UpdateWindowTitle() {
+void AppWindowGtk::UpdateWindowTitle() {
string16 title = shell_window_->GetTitle();
gtk_window_set_title(window_, UTF16ToUTF8(title).c_str());
}
-void ShellWindowGtk::HandleKeyboardEvent(
+void AppWindowGtk::HandleKeyboardEvent(
const content::NativeWebKeyboardEvent& event) {
// No-op.
}
-void ShellWindowGtk::UpdateDraggableRegions(
+void AppWindowGtk::UpdateDraggableRegions(
const std::vector<extensions::DraggableRegion>& regions) {
// Draggable region is not supported for non-frameless window.
if (!frameless_)
@@ -364,7 +364,7 @@ void ShellWindowGtk::UpdateDraggableRegions(
}
// static
-NativeShellWindow* NativeShellWindow::Create(
+AppBaseWindow* AppBaseWindow::Create(
ShellWindow* shell_window, const ShellWindow::CreateParams& params) {
- return new ShellWindowGtk(shell_window, params);
+ return new AppWindowGtk(shell_window, params);
}

Powered by Google App Engine
This is Rietveld 408576698