Add Search-. as a shortcut for the Insert key when Search is acting as a Function key.

chrome/browser/ui/ash/event_rewriter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/event_rewriter.h"
 
 #include <vector>
 
 #include "ash/shell.h"
 #include "base/logging.h"
@@ skipping 262 matching lines @@
     // |device_id| is unknown. This means the device was connected before
     // booting the OS. Query the name of the device and add it to the map.
     DeviceAdded(device_id);
   }
 
   last_device_id_ = device_id;
 }
 
 void EventRewriter::RefreshKeycodes() {
   Display* display = ui::GetXDisplay();
   control_l_xkeycode_ = XKeysymToKeycode(display, XK_Control_L);

[Wez, 2012/11/26 21:03:19]

There are sufficiently many of these now that it'd be worth constructing a table
for this mapping, rather than expressing it in code here & in
NativeKeySymToNativeKeycode().

[Yusuke Sato, 2012/11/30 23:43:55]

+1

   control_r_xkeycode_ = XKeysymToKeycode(display, XK_Control_R);
   alt_l_xkeycode_ = XKeysymToKeycode(display, XK_Alt_L);
   alt_r_xkeycode_ = XKeysymToKeycode(display, XK_Alt_R);
   meta_l_xkeycode_ = XKeysymToKeycode(display, XK_Meta_L);
   meta_r_xkeycode_ = XKeysymToKeycode(display, XK_Meta_R);
   windows_l_xkeycode_ = XKeysymToKeycode(display, XK_Super_L);
   caps_lock_xkeycode_ = XKeysymToKeycode(display, XK_Caps_Lock);
   void_symbol_xkeycode_ = XKeysymToKeycode(display, XK_VoidSymbol);
   delete_xkeycode_ = XKeysymToKeycode(display, XK_Delete);
   home_xkeycode_ = XKeysymToKeycode(display, XK_Home);
   end_xkeycode_ = XKeysymToKeycode(display, XK_End);
   prior_xkeycode_ = XKeysymToKeycode(display, XK_Prior);
   next_xkeycode_ = XKeysymToKeycode(display, XK_Next);
+  insert_xkeycode_ = XKeysymToKeycode(display, XK_Insert);
   kp_0_xkeycode_ = XKeysymToKeycode(display, XK_KP_0);
   kp_1_xkeycode_ = XKeysymToKeycode(display, XK_KP_1);
   kp_2_xkeycode_ = XKeysymToKeycode(display, XK_KP_2);
   kp_3_xkeycode_ = XKeysymToKeycode(display, XK_KP_3);
   kp_4_xkeycode_ = XKeysymToKeycode(display, XK_KP_4);
   kp_5_xkeycode_ = XKeysymToKeycode(display, XK_KP_5);
   kp_6_xkeycode_ = XKeysymToKeycode(display, XK_KP_6);
   kp_7_xkeycode_ = XKeysymToKeycode(display, XK_KP_7);
   kp_8_xkeycode_ = XKeysymToKeycode(display, XK_KP_8);
   kp_9_xkeycode_ = XKeysymToKeycode(display, XK_KP_9);
@@ skipping 47 matching lines @@
     case XK_Delete:
       return delete_xkeycode_;
     case XK_Home:
       return home_xkeycode_;
     case XK_End:
       return end_xkeycode_;
     case XK_Prior:
       return prior_xkeycode_;
     case XK_Next:
       return next_xkeycode_;
+    case XK_Insert:
+      return insert_xkeycode_;
     case XK_KP_0:
       return kp_0_xkeycode_;
     case XK_KP_1:
       return kp_1_xkeycode_;
     case XK_KP_2:
       return kp_2_xkeycode_;
     case XK_KP_3:
       return kp_3_xkeycode_;
     case XK_KP_4:
       return kp_4_xkeycode_;
@@ skipping 21 matching lines @@
   // Do not rewrite an event sent by ui_controls::SendKeyPress(). See
   // crbug.com/136465.
   if (event->native_event()->xkey.send_event)
     return ash::EventRewriterDelegate::ACTION_REWRITE_EVENT;
 
   if (DropSearchKey(event))
     return ash::EventRewriterDelegate::ACTION_DROP_EVENT;
 #endif
   RewriteModifiers(event);
   RewriteNumPadKeys(event);
-  RewriteBackspaceAndArrowKeys(event);
+  RewriteBackspaceBackslashAndArrowKeys(event);
   RewriteFunctionKeys(event);
   return ash::EventRewriterDelegate::ACTION_REWRITE_EVENT;
 }
 
 bool EventRewriter::IsAppleKeyboard() const {
   if (last_device_id_ == kBadDeviceId)
     return false;
 
   // Check which device generated |event|.
   std::map<int, DeviceType>::const_iterator iter =
@@ skipping 250 matching lines @@
       break;
     default:
       break;
   }
 #else
   // TODO(yusukes): Support Ash on other platforms if needed.
 #endif
   return rewritten;
 }
 
-bool EventRewriter::RewriteBackspaceAndArrowKeys(ui::KeyEvent* event) {
+bool EventRewriter::RewriteBackspaceBackslashAndArrowKeys(ui::KeyEvent* event) {
   bool rewritten = false;
 #if defined(OS_CHROMEOS)
   const PrefService* pref_service =
       pref_service_ ? pref_service_ : GetPrefService();
 
   const bool search_as_function_key = pref_service &&
       pref_service->GetBoolean(prefs::kLanguageSearchKeyActsAsFunctionKey);
 
   XEvent* xev = event->native_event();
   XKeyEvent* xkey = &(xev->xkey);
@@ skipping 58 matching lines @@
     // Without Search as Function key: Remap Alt+Down to Next (aka PageDown).
     OverwriteEvent(event, next_xkeycode_, xkey->state & ~Mod1Mask,
                    ui::VKEY_NEXT, event->flags() & ~ui::EF_ALT_DOWN);
     rewritten = true;
   } else if (search_as_function_key &&
              keysym == XK_Down && (xkey->state & Mod4Mask)) {
     // With Search as Function key: Remap Search+Down to Next (aka PageDown).
     OverwriteEvent(event, next_xkeycode_, xkey->state & ~Mod4Mask,
                    ui::VKEY_NEXT, event->flags());
     rewritten = true;
+  } else if (search_as_function_key &&

[Wez, 2012/11/26 21:03:19]

nit: This function would be easier to read if it had separate blocks for
|search_as_function_key|.

+             keysym == XK_backslash && (xkey->state & Mod4Mask)) {

[Yusuke Sato, 2012/11/26 07:54:44]

\ might be a bit inconvenient for non-US versions of Chromebooks (Lucas is
available in UK as you know, and Alex actually supports 5-6 types of European
hardware keyboards). On UK Chromebook, \ is not placed below backspace:
http://en.wikipedia.org/wiki/Keyboard_layout#United_Kingdom . Many European
layouts require AltGr to type \.

How about mapping Search+Esc to Insert instead? As far as I know, all keyboard
layouts has the key and the position of the key is fixed.

[danakj, 2012/11/26 17:47:28]

Sure that sounds fine. :)

[Wez, 2012/11/26 21:03:19]

Agreed; "\" not only changes location between US & UK layouts, the UK layout
doesn't even have a key in the UK layout's "\" location, or vice versa.

Search+Esc doesn't seem a particularly logical place for Insert; what about
Search+"-" or Search+"+", so it's at least near Backspace?

In general we should design the function-mode layout in its entirety for the
keys we currently need, rather than add them in piecemeal, so that we can have
some consistent placement, e.g. arranging Home, Insert, etc so that they have
roughly the same physical placement as on a normal keyboard.

[Yusuke Sato, 2012/11/26 21:08:28]

Unfortunately - and = are already used for F11 and F12..

+    // With Search as Function key: Remap Search+backslash to Insert.
+    OverwriteEvent(event, insert_xkeycode_, xkey->state & ~Mod4Mask,
+                   ui::VKEY_INSERT, event->flags());
+    rewritten = true;
   }
 #else
   // TODO(yusukes): Support Ash on other platforms if needed.
 #endif
   return rewritten;
 }
 
 bool EventRewriter::RewriteFunctionKeys(ui::KeyEvent* event) {
 #if defined(OS_CHROMEOS)
   XEvent* xev = event->native_event();
@@ skipping 280 matching lines @@
   const DeviceType type = EventRewriter::GetDeviceType(device_name);
   if (type == kDeviceAppleKeyboard) {
     VLOG(1) << "Apple keyboard '" << device_name << "' connected: "
             << "id=" << device_id;
   }
   // Always overwrite the existing device_id since the X server may reuse a
   // device id for an unattached device.
   device_id_to_type_[device_id] = type;
   return type;
 }