Issue 11280148: [dart2dart] triage language tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280148: [dart2dart] triage language tests (Closed)

Created:
8 years, 1 month ago by Roman

Modified:
8 years, 1 month ago

Reviewers:
Anton Muhin, antonm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

[dart2dart] triage language tests Committed: https://code.google.com/p/dart/source/detail?r=15283

Patch Set 3 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	tests/language/language.status	View	1 2	1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

lgtm and thanks a lot https://chromiumcodereview.appspot.com/11280148/diff/2002/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/11280148/diff/2002/tests/language/language.status#newcode391 tests/language/language.status:391: many_overridden_no_such_method_test: Fail, Pass # ...

8 years, 1 month ago (2012-11-23 12:46:50 UTC) #2

Roman

8 years, 1 month ago (2012-11-23 13:20:47 UTC) #3

https://chromiumcodereview.appspot.com/11280148/diff/2002/tests/language/lang...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/11280148/diff/2002/tests/language/lang...
tests/language/language.status:391: many_overridden_no_such_method_test: Fail,
Pass # Fails in minified mode, test depends on method names.
On 2012/11/23 12:46:51, antonm wrote:
> please, add Ok modifier to this expectation and one below

Done.

Expand Messages | Collapse Messages

Issue 11280148: [dart2dart] triage language tests (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages