Create CachingRietveld to automatically cache results for presubmit checks.

rietveld.py

 # coding: utf-8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Defines class Rietveld to easily access a rietveld instance.
 
 Security implications:
 
 The following hypothesis are made:
 - Rietveld enforces:
   - Nobody else than issue owner can upload a patch set
   - Verifies the issue owner credentials when creating new issues
   - A issue owner can't change once the issue is created
   - A patch set cannot be modified
 """
 
+import copy
 import json
 import logging
 import re
 import time
 import urllib2
 
 from third_party import upload
 import patch
 
 # Hack out upload logging.info()
@@ skipping 361 matching lines @@
           if not 'Name or service not known' in e.reason:
             # Usually internal GAE flakiness.
             raise
         # If reaching this line, loop again. Uses a small backoff.
         time.sleep(1+maxtries*2)
     finally:
       upload.ErrorExit = old_error_exit
 
   # DEPRECATED.
   Send = get
+
+
+class CachingRietveld(Rietveld):
+  """Caches the common queries.
+
+  Not to be used in long-standing processes, like the commit queue.
+  """
+  def __init__(self, *args, **kwargs):
+    super(CachingRietveld, self).__init__(*args, **kwargs)
+    self._cache = {}
+
+  def _lookup(self, function_name, args, update):
+    """Caches the return values corresponding to the arguments.
+
+    It is important that the arguments are standardized, like None vs False.
+    """
+    function_cache = self._cache.setdefault(function_name, {})
+    if args not in function_cache:
+      function_cache[args] = update(*args)
+    return copy.deepcopy(function_cache[args])
+
+  def get_description(self, issue):
+    return self._lookup(
+        'get_description',
+        (issue,),
+        super(CachingRietveld, self).get_description)
+
+  def get_issue_properties(self, issue, messages):

[Isaac (away), 2012/11/26 05:12:39]

get_issue_properties(<issue>, True) returns a superset of
get_issue_properties(<issue>, False).

Could we modify this for the False call to return the True call if it is cached?

[M-A Ruel, 2012/11/27 20:15:06]

Done

+    return self._lookup(
+        'get_issue_properties',
+        (issue, bool(messages)),
+        super(CachingRietveld, self).get_issue_properties)
+
+  def get_patchset_properties(self, issue, patchset):
+    return self._lookup(
+        'get_patchset_properties',
+        (issue, patchset),
+        super(CachingRietveld, self).get_patchset_properties)