Issue 11280118: Object.observe: More tests for accessor reconfiguration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280118: Object.observe: More tests for accessor reconfiguration. (Closed)

Created:
8 years, 1 month ago by rossberg

Modified:
8 years, 1 month ago

Reviewers:
rafaelw, adamk

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Object.observe: More tests for accessor reconfiguration. R=adamk@chromium.org,rafaelw@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13035

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -4 lines)			Patch
	M	test/mjsunit/harmony/object-observe.js	View		7 chunks	+26 lines, -4 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

adamk

LGTM with one question. https://codereview.chromium.org/11280118/diff/1/test/mjsunit/harmony/object-observe.js File test/mjsunit/harmony/object-observe.js (right): https://codereview.chromium.org/11280118/diff/1/test/mjsunit/harmony/object-observe.js#newcode454 test/mjsunit/harmony/object-observe.js:454: Object.defineProperty(obj, prop, {get: function() {}}); ...

8 years, 1 month ago (2012-11-21 16:24:31 UTC) #2

rossberg

https://codereview.chromium.org/11280118/diff/1/test/mjsunit/harmony/object-observe.js File test/mjsunit/harmony/object-observe.js (right): https://codereview.chromium.org/11280118/diff/1/test/mjsunit/harmony/object-observe.js#newcode454 test/mjsunit/harmony/object-observe.js:454: Object.defineProperty(obj, prop, {get: function() {}}); // ignored On 2012/11/21 ...

8 years, 1 month ago (2012-11-21 16:57:03 UTC) #3

lgtm

Expand Messages | Collapse Messages