Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 11280114: Fix Telemetry after r168902 / r168927. (Closed)

Created:
8 years, 1 month ago by bulach
Modified:
8 years, 1 month ago
Reviewers:
tonyg, hartmanng
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

Fix Telemetry after r168902 / r168927. DoNothingForwarder needs the same fix as applied in r168927. BUG= TEST=./tools/telemetry/run_tests --browser=system testConsole Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/telemetry/telemetry/desktop_browser_backend.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bulach
ptal
8 years, 1 month ago (2012-11-21 10:09:47 UTC) #1
hartmanng
lgtm
8 years, 1 month ago (2012-11-21 13:48:47 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 1 month ago (2012-11-21 13:52:57 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 1 month ago (2012-11-21 13:53:38 UTC) #4
tonyg
lgtm
8 years, 1 month ago (2012-11-21 17:48:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11280114/1
8 years, 1 month ago (2012-11-21 17:48:35 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-21 20:46:00 UTC) #7
Change committed as 169117

Powered by Google App Engine
This is Rietveld 408576698