win8/metro_driver/metro_driver.gyp - Issue 11280112: UMA for Windows 8 Secondary Tile pinning/unpinning user actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win8/metro_driver/metro_driver.gyp

Issue 11280112: UMA for Windows 8 Secondary Tile pinning/unpinning user actions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: **fails presubmit** make secondary_tile_types.h, +review comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win8/metro_driver/metro_driver.gyp

diff --git a/win8/metro_driver/metro_driver.gyp b/win8/metro_driver/metro_driver.gyp

index 0d0081bab5711c415498bd78ae3af566b70782f0..1ded952ee970ca7f2f73b0f659077e87118a245e 100644

--- a/win8/metro_driver/metro_driver.gyp

+++ b/win8/metro_driver/metro_driver.gyp

@@ -98,6 +98,7 @@

'print_document_source.h',

'secondary_tile.h',

'secondary_tile.cc',

+ 'secondary_tile_types.h',

MAD 2012/11/29 15:26:18 I don't see this file in your CL?

tapted 2012/11/30 00:30:31 Drat silly mistake :-/ - the contents will move ba

'settings_handler.cc',

'settings_handler.h',

'toast_notification_handler.cc',

« chrome/chrome_browser_ui.gypi ('K') | « win8/metro_driver/chrome_app_view.cc ('k') | win8/metro_driver/secondary_tile.h » ('j') | win8/metro_driver/secondary_tile.cc » ('J')