UMA for Windows 8 Secondary Tile pinning/unpinning user actions

chrome/browser/ui/metro_pin_tab_helper_win.cc

Index: chrome/browser/ui/metro_pin_tab_helper_win.cc
diff --git a/chrome/browser/ui/metro_pin_tab_helper_win.cc b/chrome/browser/ui/metro_pin_tab_helper_win.cc
index 6491efa71cfdd04e38b9a93b3559196e82b0f558..cba5951062a81a7030c06f63af3d3ef87ba7c26e 100644
--- a/chrome/browser/ui/metro_pin_tab_helper_win.cc
+++ b/chrome/browser/ui/metro_pin_tab_helper_win.cc
@@ -13,6 +13,7 @@
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/ref_counted_memory.h"
+#include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
@@ -40,6 +41,9 @@ DEFINE_WEB_CONTENTS_USER_DATA_KEY(MetroPinTabHelper)
 
 namespace {
 
+// Histogram name for site-specific tile pinning metrics.
+const char kMetroPinMetric[] = "Metro.SecondaryTilePin";
+
 // Generate an ID for the tile based on |url_str|. The ID is simply a hash of
 // the URL.
 string16 GenerateTileId(const string16& url_str) {
@@ -158,6 +162,14 @@ bool GetPathToBackupLogo(const FilePath& logo_dir,
   return file_util::CopyFile(default_logo_path, *logo_path);
 }
 
+// UMA reporting callback for site-specific secondary tile creation.
+void PinPageReportUMACallback(void* callback_data,

[benwells, 2012/11/27 08:56:39]

callback_data doesn't seem to serve any purpose. Why plumb it all the way
through?

[tapted, 2012/11/28 00:33:43]

I think my fingers just balked at making a callback API with no way to pass
through user data ;-). Since, that limits a callback to accessing static/global
data only. Which, for UMA, it is. So, I didn't end up using it, even though the
caller -- MetroPinTabHelper -- is per-tab.

I'll cut it out. [Done.]

[benwells, 2012/11/29 04:19:46]

If you really want to pass callback data through you can always curry it in with
base::bind later on. That's the way we roll.

+                              base::win::MetroSecondaryTilePinState result) {
+  UMA_HISTOGRAM_ENUMERATION(kMetroPinMetric,
+                            result,
+                            base::win::METRO_PIN_STATE_LIMIT);
+}
+
 // The PinPageTaskRunner class performs the necessary FILE thread actions to
 // pin a page, such as generating or copying the tile image file. When it
 // has performed these actions it will send the tile creation request to the
@@ -218,22 +230,28 @@ void PinPageTaskRunner::RunOnFileThread() {
     LOG(ERROR) << "Count not get path to logo tile.";
     return;
   }
+  UMA_HISTOGRAM_ENUMERATION(kMetroPinMetric,
+                            base::win::METRO_PIN_LOGO_READY,
+                            base::win::METRO_PIN_STATE_LIMIT);
 
   HMODULE metro_module = base::win::GetMetroModule();
   if (!metro_module)
     return;
 
-  typedef void (*MetroPinToStartScreen)(const string16&, const string16&,
-      const string16&, const FilePath&);
-  MetroPinToStartScreen metro_pin_to_start_screen =
-      reinterpret_cast<MetroPinToStartScreen>(
+  base::win::MetroPinToStartScreen metro_pin_to_start_screen =
+      reinterpret_cast<base::win::MetroPinToStartScreen>(
           ::GetProcAddress(metro_module, "MetroPinToStartScreen"));
   if (!metro_pin_to_start_screen) {
     NOTREACHED();
     return;
   }
 
-  metro_pin_to_start_screen(tile_id, title_, url_, logo_path);
+  metro_pin_to_start_screen(tile_id,
+                            title_,
+                            url_,
+                            logo_path,
+                            &PinPageReportUMACallback,
+                            NULL);
 }
 
 }  // namespace
@@ -378,10 +396,16 @@ bool MetroPinTabHelper::IsPinned() const {
 
 void MetroPinTabHelper::TogglePinnedToStartScreen() {
   if (IsPinned()) {
+    UMA_HISTOGRAM_ENUMERATION(kMetroPinMetric,
+                              base::win::METRO_UNPIN_INITIATED,
+                              base::win::METRO_PIN_STATE_LIMIT);
     UnPinPageFromStartScreen();
     return;
   }
 
+  UMA_HISTOGRAM_ENUMERATION(kMetroPinMetric,
+                            base::win::METRO_PIN_INITIATED,
+                            base::win::METRO_PIN_STATE_LIMIT);
   GURL url = web_contents()->GetURL();
   string16 url_str = UTF8ToUTF16(url.spec());
   string16 title = web_contents()->GetTitle();
@@ -445,9 +469,8 @@ void MetroPinTabHelper::UnPinPageFromStartScreen() {
   if (!metro_module)
     return;
 
-  typedef void (*MetroUnPinFromStartScreen)(const string16&);
-  MetroUnPinFromStartScreen metro_un_pin_from_start_screen =
-      reinterpret_cast<MetroUnPinFromStartScreen>(
+  base::win::MetroUnPinFromStartScreen metro_un_pin_from_start_screen =
+      reinterpret_cast<base::win::MetroUnPinFromStartScreen>(
           ::GetProcAddress(metro_module, "MetroUnPinFromStartScreen"));
   if (!metro_un_pin_from_start_screen) {
     NOTREACHED();
@@ -456,7 +479,7 @@ void MetroPinTabHelper::UnPinPageFromStartScreen() {
 
   GURL url = web_contents()->GetURL();
   string16 tile_id = GenerateTileId(UTF8ToUTF16(url.spec()));
-  metro_un_pin_from_start_screen(tile_id);
+  metro_un_pin_from_start_screen(tile_id, &PinPageReportUMACallback, NULL);
 }
 
 void MetroPinTabHelper::FaviconDownloaderFinished() {