chrome/installer/gcapi/gcapi_omaha_experiment.h - Issue 11280067: Refactor SetOmahaExperimentLabel out of gcpai and into install_util.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/gcapi/gcapi_omaha_experiment.h

Issue 11280067: Refactor SetOmahaExperimentLabel out of gcpai and into install_util. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/gcapi/gcapi_omaha_experiment.h

diff --git a/chrome/installer/gcapi/gcapi_omaha_experiment.h b/chrome/installer/gcapi/gcapi_omaha_experiment.h

index 16fbdb35777209148228796cb96ebda056f256fd..a59a6264f2e5517a60152925bf3ffbf9893e5c6a 100644

--- a/chrome/installer/gcapi/gcapi_omaha_experiment.h

+++ b/chrome/installer/gcapi/gcapi_omaha_experiment.h

@@ -5,6 +5,11 @@

#ifndef CHROME_INSTALLER_GCAPI_GCAPI_OMAHA_EXPERIMENT_H_

#define CHROME_INSTALLER_GCAPI_GCAPI_OMAHA_EXPERIMENT_H_

-bool SetOmahaExperimentLabel(const wchar_t* brand_code, int shell_mode);

+// Writes a reactivation brand code experiment label in the Chrome product and

+// binaries registry keys for |brand_code|. This experiment label will have a

+// expiration date of now plus one year. If |shell_mode| is set to

+// GCAPI_INVOKED_UAC_ELEVATION, the value will be written to HKLM, otherwise

+// HKCU.

+bool SetGCAPIOmahaExperimentLabel(const wchar_t* brand_code, int shell_mode);

grt (UTC plus 2) 2012/11/24 02:58:37 "SetReactivationExperimentLabels" seems more accur

SteveT 2012/11/26 20:45:06 Sure, let's be more specific now that we've refact

#endif // CHROME_INSTALLER_GCAPI_GCAPI_OMAHA_EXPERIMENT_H_

« no previous file with comments | « chrome/installer/gcapi/gcapi.cc ('k') | chrome/installer/gcapi/gcapi_omaha_experiment.cc » ('j') | chrome/installer/util/browser_distribution.h » ('J')