Refactor SetOmahaExperimentLabel out of gcpai and into install_util.

chrome/installer/util/install_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // See the corresponding header file for description of the functions in this
 // file.
 
 #include "chrome/installer/util/install_util.h"
 
 #include <shellapi.h>
@@ skipping 100 matching lines @@
                    screen_rect.top + y_offset,
                    0, 0, FALSE);
     } else {
       NOTREACHED() << "Unable to get default monitor";
     }
     ::SetForegroundWindow(foreground_window);
   }
   return foreground_window;
 }
 
+const wchar_t kExperimentLabels[] = L"experiment_labels";
+
+const wchar_t* kExperimentAppGuids[] = {
+    L"{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D}",
+    L"{8A69D345-D564-463C-AFF1-A69D9E530F96}",
+};

[robertshield, 2012/11/20 15:29:49]

move these up next to the other constants

[SteveT, 2012/11/20 15:45:01]

Moved them up in alpha order as well. Thanks. Done.

+
 }  // namespace
 
 string16 InstallUtil::GetActiveSetupPath(BrowserDistribution* dist) {
   static const wchar_t kInstalledComponentsPath[] =
       L"Software\\Microsoft\\Active Setup\\Installed Components\\";
   return kInstalledComponentsPath + dist->GetAppGuid();
 }
 
 void InstallUtil::TriggerActiveSetupCommandIfNeeded() {
   FilePath chrome_exe;
@@ skipping 385 matching lines @@
                            date_str, arraysize(date_str));
   if (len) {
     --len;  // Subtract terminating \0.
   } else {
     PLOG(DFATAL) << "GetDateFormat";
   }
 
   return string16(date_str, len);
 }
 
+// static
+bool InstallUtil::SetOmahaExperimentLabel(const string16& experiment_label,
+                                          HKEY registry_hive) {
+  int successful_writes = 0;
+  for (int i = 0; i < arraysize(kExperimentAppGuids); ++i) {
+    string16 experiment_path(google_update::kRegPathClientState);
+    experiment_path += L"\\";
+    experiment_path += kExperimentAppGuids[i];
+
+    RegKey client_state(registry_hive, experiment_path.c_str(),
+                        KEY_SET_VALUE);
+    if (client_state.Valid()) {
+      if (client_state.WriteValue(kExperimentLabels,
+                                  experiment_label.c_str()) == ERROR_SUCCESS) {

[robertshield, 2012/11/20 15:29:49]

nit: collapse this to a single if to reduce indentation:

if (client_state.Valid() &&
    client_state.WriteValue(kExperimentLabels,
                            experiment_label.c_str()) == ERROR_SUCCESS)

[SteveT, 2012/11/20 15:45:01]

Done.

+        successful_writes++;
+      }
+    }
+  }
+
+  return (successful_writes == arraysize(kExperimentAppGuids));
+}
+
 // Open |path| with minimal access to obtain information about it, returning
 // true and populating |handle| on success.
 // static
 bool InstallUtil::ProgramCompare::OpenForInfo(const FilePath& path,
                                               base::win::ScopedHandle* handle) {
   DCHECK(handle);
   handle->Set(base::CreatePlatformFile(path, base::PLATFORM_FILE_OPEN, NULL,
                                        NULL));
   return handle->IsValid();
 }
@@ skipping 49 matching lines @@
   // Open the program and see if it references the expected file.
   base::win::ScopedHandle handle;
   BY_HANDLE_FILE_INFORMATION info = {};
 
   return (OpenForInfo(program, &handle) &&
           GetInfo(handle, &info) &&
           info.dwVolumeSerialNumber == file_info_.dwVolumeSerialNumber &&
           info.nFileIndexHigh == file_info_.nFileIndexHigh &&
           info.nFileIndexLow == file_info_.nFileIndexLow);
 }