Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 11280061: Revert "Added support for skipping redundant dart2js compilations." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/test_runner_exit_code_script.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index 421ea149a482db025bf6ccab4d1ff5c06cb9ef2b..68ee94572660968087aacf2ac5d6ba266899eba1 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -53,10 +53,6 @@ class ProgressIndicator {
}
_appendToFlakyFile(buf.toString());
}
- for (var commandOutput in test.commandOutputs.values) {
- if (commandOutput.compilationSkipped)
- _skippedCompilations++;
- }
if (test.lastCommandOutput.unexpectedOutput) {
_failedTests++;
@@ -75,13 +71,6 @@ class ProgressIndicator {
_allTestsKnown = true;
}
- void _printSkippedCompilationInfo() {
- if (_skippedCompilations > 0) {
- print('\n$_skippedCompilations compilations were skipped because '
- 'the previous output was already up to date\n');
- }
- }
-
void _printTimingInformation() {
if (_printTiming) {
// TODO: We should take all the commands into account
@@ -104,7 +93,6 @@ class ProgressIndicator {
void allDone() {
_printFailureSummary();
_printStatus();
- _printSkippedCompilationInfo();
_printTimingInformation();
stdout.close();
stderr.close();
@@ -237,7 +225,6 @@ class ProgressIndicator {
int _foundTests = 0;
int _passedTests = 0;
int _failedTests = 0;
- int _skippedCompilations = 0;
bool _allTestsKnown = false;
Date _startTime;
bool _printTiming;
@@ -265,7 +252,6 @@ abstract class CompactIndicator extends ProgressIndicator {
void allDone() {
stdout.write('\n'.charCodes);
_printFailureSummary();
- _printSkippedCompilationInfo();
_printTimingInformation();
if (_failedTests > 0) {
// We may have printed many failure logs, so reprint the summary data.
« no previous file with comments | « tests/standalone/io/test_runner_exit_code_script.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698