runtime/vm/dart_api_message.cc - Issue 11280059: Always zero-initialize array used for mapping VM symbols to Dart_CObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_message.cc

Issue 11280059: Always zero-initialize array used for mapping VM symbols to Dart_CObject (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_message.cc

diff --git a/runtime/vm/dart_api_message.cc b/runtime/vm/dart_api_message.cc

index b661136f5dbbda611ce071d400ef005ac19db8ce..4cee392ee75564f19ef8bdd909d8116b9ed76e27 100644

--- a/runtime/vm/dart_api_message.cc

+++ b/runtime/vm/dart_api_message.cc

@@ -227,9 +227,7 @@ Dart_CObject* ApiMessageReader::ReadVMSymbol(intptr_t object_id) {

intptr_t size = sizeof(*vm_symbol_references_) * Symbols::kMaxId;

vm_symbol_references_ =

reinterpret_cast<Dart_CObject**>(alloc_(NULL, 0, size));

-#ifdef DEBUG

memset(vm_symbol_references_, 0, size);

-#endif

}

RawOneByteString* str =

« no previous file with comments | « no previous file | no next file » | no next file with comments »