Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128003005: Tidy public/ directory. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tidy public/ directory. - Make include guards consistent with standard and filenames. - Remove stray semicolon folowing extern "C" section close-brace. - Untabify. - Delete trailing whitespace. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8aa1eac606d8e5030de6509f5d5d66e90db521f4

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Total comments: 10

Patch Set 4 : Fix typos, extra space. #

Patch Set 5 : Missed one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2037 lines, -2055 lines) Patch
M public/fpdf_dataavail.h View 1 2 2 chunks +118 lines, -119 lines 0 comments Download
M public/fpdf_doc.h View 1 2 3 4 4 chunks +123 lines, -123 lines 0 comments Download
M public/fpdf_edit.h View 5 chunks +124 lines, -123 lines 0 comments Download
M public/fpdf_ext.h View 1 2 1 chunk +57 lines, -59 lines 0 comments Download
M public/fpdf_flatten.h View 1 chunk +27 lines, -27 lines 0 comments Download
M public/fpdf_formfill.h View 3 chunks +634 lines, -636 lines 0 comments Download
M public/fpdf_fwlevent.h View 1 2 3 3 chunks +87 lines, -89 lines 0 comments Download
M public/fpdf_ppo.h View 2 chunks +18 lines, -19 lines 0 comments Download
M public/fpdf_progressive.h View 2 chunks +55 lines, -55 lines 0 comments Download
M public/fpdf_save.h View 1 2 2 chunks +45 lines, -46 lines 0 comments Download
M public/fpdf_searchex.h View 1 2 3 4 1 chunk +11 lines, -15 lines 0 comments Download
M public/fpdf_sysfontinfo.h View 1 2 chunks +183 lines, -183 lines 0 comments Download
M public/fpdf_text.h View 2 chunks +155 lines, -155 lines 0 comments Download
M public/fpdf_transformpage.h View 1 2 6 chunks +45 lines, -47 lines 0 comments Download
M public/fpdfview.h View 1 2 3 5 chunks +355 lines, -359 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, for review. Second part of last week's CL.
5 years, 7 months ago (2015-05-11 23:01:18 UTC) #2
Lei Zhang
https://codereview.chromium.org/1128003005/diff/40001/public/fpdf_doc.h File public/fpdf_doc.h (right): https://codereview.chromium.org/1128003005/diff/40001/public/fpdf_doc.h#newcode269 public/fpdf_doc.h:269: #endif // PUBLIC_FPDF_DOC_H_ still got a tab here? https://codereview.chromium.org/1128003005/diff/40001/public/fpdf_fwlevent.h ...
5 years, 7 months ago (2015-05-13 21:40:35 UTC) #3
Tom Sepez
https://codereview.chromium.org/1128003005/diff/40001/public/fpdf_doc.h File public/fpdf_doc.h (right): https://codereview.chromium.org/1128003005/diff/40001/public/fpdf_doc.h#newcode269 public/fpdf_doc.h:269: #endif // PUBLIC_FPDF_DOC_H_ On 2015/05/13 21:40:34, Lei Zhang wrote: ...
5 years, 7 months ago (2015-05-13 22:17:02 UTC) #4
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-13 22:26:40 UTC) #5
Tom Sepez
5 years, 7 months ago (2015-05-13 23:39:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
8aa1eac606d8e5030de6509f5d5d66e90db521f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698