Issue 11280010: Extract SIGPIPE ignoring code to a common place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11280010: Extract SIGPIPE ignoring code to a common place. (Closed)

Created:
8 years, 1 month ago by Paweł Hajdan Jr.

Modified:
8 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit), willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, jam, kkania, sail+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extract SIGPIPE ignoring code to a common place. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168239

Patch Set 1 #

Patch Set 2 : fix ios #

Total comments: 1

Patch Set 3 : documented return value #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -28 lines)			Patch
M	base/debug/stack_trace_android.cc	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	base/debug/stack_trace_posix.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	base/process_util.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	base/process_util_posix.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/web_socket_proxy.cc	View		3 chunks	+2 lines, -13 lines	0 comments	Download
M	chrome/test/webdriver/webdriver_server.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	content/app/content_main_runner.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/flip_server/flip_in_mem_edsm_server.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

lgtm https://codereview.chromium.org/11280010/diff/3001/base/process_util.h File base/process_util.h (right): https://codereview.chromium.org/11280010/diff/3001/base/process_util.h#newcode151 base/process_util.h:151: // Ignores SIGPIPE signal. We handle pipe errors ...

8 years, 1 month ago (2012-11-16 05:25:03 UTC) #2

lgtm

Expand Messages | Collapse Messages