Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1127983003: Use function wrapper argument to expose internal arrays to native scripts. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use function wrapper argument to expose internal arrays to native scripts. R=jkummerow@chromium.org Committed: https://crrev.com/a9b5a1795449d94387218d25baed2c2b3c4fbadc Cr-Commit-Position: refs/heads/master@{#28354}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased and fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -117 lines) Patch
M src/array.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 14 chunks +122 lines, -97 lines 0 comments Download
M src/contexts.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/date.js View 1 chunk +6 lines, -0 lines 0 comments Download
M src/harmony-array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-object.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-spread.js View 1 chunk +7 lines, -1 line 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 1 1 chunk +1 line, -1 line 0 comments Download
M src/json.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/math.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/messages.js View 1 2 chunks +7 lines, -2 lines 0 comments Download
M src/object-observe.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M src/promise.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/regexp.js View 1 chunk +6 lines, -0 lines 0 comments Download
M src/string.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/templates.js View 1 chunk +11 lines, -3 lines 0 comments Download
M src/uri.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +53 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-1878.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
5 years, 7 months ago (2015-05-11 14:12:20 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127983003/1
5 years, 7 months ago (2015-05-11 15:08:45 UTC) #3
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/1127983003/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/1127983003/diff/1/src/bootstrapper.cc#newcode2207 src/bootstrapper.cc:2207: // Install natives. Everything exported to ...
5 years, 7 months ago (2015-05-11 15:25:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-11 15:33:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127983003/20001
5 years, 7 months ago (2015-05-12 05:44:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 06:14:24 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a9b5a1795449d94387218d25baed2c2b3c4fbadc Cr-Commit-Position: refs/heads/master@{#28354}
5 years, 7 months ago (2015-05-12 06:14:43 UTC) #11
Yang
5 years, 7 months ago (2015-05-12 07:25:32 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1123353008/ by yangguo@chromium.org.

The reason for reverting is: custom snapshot builder failing..

Powered by Google App Engine
This is Rietveld 408576698