Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: src/IceOperand.h

Issue 1127963004: Subzero ARM: lowerArguments (GPR), basic legalize(), and lowerRet(i32, i64). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: fix warnings, etc Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceInstX8632.cpp ('k') | src/IceTargetLowering.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceOperand.h
diff --git a/src/IceOperand.h b/src/IceOperand.h
index 430a565f418430efaec77976a0a5873d78c53f40..4ae217c5f3b36676469e1dd635920ecd0d1e0704 100644
--- a/src/IceOperand.h
+++ b/src/IceOperand.h
@@ -46,7 +46,10 @@ public:
kVariable_Target, // leave space for target-specific variable kinds
kVariable_Num = kVariable_Target + MaxTargetKinds,
// Target-specific operand classes use kTarget as the starting
- // point for their Kind enum space.
+ // point for their Kind enum space. Note that the value-spaces are shared
+ // across targets. To avoid confusion over the definition of shared
+ // values, an object specific to one target should never be passed
+ // to a different target.
kTarget
};
OperandKind getKind() const { return Kind; }
« no previous file with comments | « src/IceInstX8632.cpp ('k') | src/IceTargetLowering.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698