Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1656)

Unified Diff: cc/test/layer_tree_test.cc

Issue 1127963003: Revert of cc: Adding DidFinishImplFrame to LTHI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/layer_tree_test.h ('k') | cc/trees/layer_tree_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/layer_tree_test.cc
diff --git a/cc/test/layer_tree_test.cc b/cc/test/layer_tree_test.cc
index e782f08f845dcbdf0a094aa8b50715124468ac45..055d0817d30466ff13be525e2b5edc9dedb5bd5a 100644
--- a/cc/test/layer_tree_test.cc
+++ b/cc/test/layer_tree_test.cc
@@ -81,6 +81,11 @@
private:
TestHooks* test_hooks_;
+ void WillBeginImplFrame(const BeginFrameArgs& args) override {
+ ThreadProxy::WillBeginImplFrame(args);
+ test_hooks_->WillBeginImplFrame(args);
+ }
+
void ScheduledActionSendBeginMainFrame() override {
test_hooks_->ScheduledActionWillSendBeginMainFrame();
ThreadProxy::ScheduledActionSendBeginMainFrame();
@@ -116,11 +121,6 @@
void ScheduledActionInvalidateOutputSurface() override {
ThreadProxy::ScheduledActionInvalidateOutputSurface();
test_hooks_->ScheduledActionInvalidateOutputSurface();
- }
-
- void SendBeginMainFrameNotExpectedSoon() override {
- ThreadProxy::SendBeginMainFrameNotExpectedSoon();
- test_hooks_->SendBeginMainFrameNotExpectedSoon();
}
ThreadProxyForTest(
@@ -154,6 +154,11 @@
private:
TestHooks* test_hooks_;
+ void WillBeginImplFrame(const BeginFrameArgs& args) override {
+ SingleThreadProxy::WillBeginImplFrame(args);
+ test_hooks_->WillBeginImplFrame(args);
+ }
+
void ScheduledActionSendBeginMainFrame() override {
test_hooks_->ScheduledActionWillSendBeginMainFrame();
SingleThreadProxy::ScheduledActionSendBeginMainFrame();
@@ -185,16 +190,6 @@
void ScheduledActionPrepareTiles() override {
SingleThreadProxy::ScheduledActionPrepareTiles();
test_hooks_->ScheduledActionPrepareTiles();
- }
-
- void ScheduledActionInvalidateOutputSurface() override {
- SingleThreadProxy::ScheduledActionInvalidateOutputSurface();
- test_hooks_->ScheduledActionInvalidateOutputSurface();
- }
-
- void SendBeginMainFrameNotExpectedSoon() override {
- SingleThreadProxy::SendBeginMainFrameNotExpectedSoon();
- test_hooks_->SendBeginMainFrameNotExpectedSoon();
}
SingleThreadProxyForTest(
@@ -258,11 +253,6 @@
void WillBeginImplFrame(const BeginFrameArgs& args) override {
LayerTreeHostImpl::WillBeginImplFrame(args);
test_hooks_->WillBeginImplFrameOnThread(this, args);
- }
-
- void DidFinishImplFrame() override {
- LayerTreeHostImpl::DidFinishImplFrame();
- test_hooks_->DidFinishImplFrameOnThread(this);
}
void BeginMainFrameAborted(CommitEarlyOutReason reason) override {
@@ -722,7 +712,6 @@
}
void LayerTreeTest::RealEndTest() {
- // TODO(mithro): Make this method only end when not inside an impl frame.
if (layer_tree_host_ && !timed_out_ &&
proxy()->MainFrameWillHappenForTesting()) {
main_task_runner_->PostTask(
« no previous file with comments | « cc/test/layer_tree_test.h ('k') | cc/trees/layer_tree_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698