chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc - Issue 1127963002: Implement lossy pref behavior for JsonPrefStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc

Issue 1127963002: Implement lossy pref behavior for JsonPrefStore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs-fix-flags

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/prefs/json_pref_store_unittest.cc ('K') | « base/prefs/json_pref_store_unittest.cc ('k') | chrome/browser/spellchecker/spellcheck_custom_dictionary.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc b/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc

index 6c6a9a45ff9d5dd9c78410c7e2246f679d63aea2..1d258d343e6edf9e38662afc797208891ef0f598 100644

--- a/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc

@@ -108,10 +108,10 @@ void WriteMetadataOnWorkerPool(const base::FilePath& metadata_path,

MetadataWriteResult result = NUM_WRITE_RESULTS;

std::string file_data;

if (download_metadata->SerializeToString(&file_data)) {

- result =

- base::ImportantFileWriter::WriteFileAtomically(metadata_path, file_data)

- ? WRITE_SUCCESS

- : WRITE_FAILURE;

+ result = base::ImportantFileWriterImpl::WriteFileAtomically(metadata_path,

+ file_data)

+ ? WRITE_SUCCESS

+ : WRITE_FAILURE;

} else {

result = SERIALIZATION_FAILURE;

}